Re: [PATCH v3 00/13] Add ISP 3A for StarFive

Laurent Pinchart
2024-02-12T16:33:21Z

Hi Matthias,

On Mon, Feb 12, 2024 at 01:40:57PM +0100, Matthias Brugger wrote:
> Dear Changhuang,
>
> On 05/02/2024 10:04, Changhuang Liang wrote:
> > Changhuang Liang (13):
> > media: starfive: Add JH7110 ISP module definitions
> > media: Documentation: Add description for StarFive ISP metadata
> > formats
> > media: videodev2.h, v4l2-ioctl: Add StarFive ISP meta buffer format
> > staging: media: starfive: Add a params sink pad and a scd source pad
> > for ISP
> > staging: media: starfive: Separate buffer from ISP hardware operation
> > staging: media: starfive: Separate buffer be a common file
> > staging: media: starfive: Separate ISP hardware from capture device
> > staging: media: starfive: Add for StarFive ISP 3A SC
> > staging: media: starfive: Update ISP initialise config for 3A
> > staging: media: starfive: Add V4L2_CAP_IO_MC capability
> > staging: media: starfive: Add ISP params video device
> > staging: media: starfive: Add ISP parameters hardware configure
> > admin-guide: media: Update documents for StarFive Camera Subsystem
>
> I think instead of adding more support on top of the staging driver, the first
> step would be to get the driver out of staging and make it a regular Linux
> driver. After that new HW support should be added.

We asked for the driver to be upstreamed in staging first because it was
mising important features, which this patch series implements (at least
partly, I still need to review the series in more details). I would
prefer merging the necessary features first, and destaging the driver
next, right after.

--
Regards,

Laurent Pinchart