Re: [PATCH] greybus: Avoid fake flexible array for response data

Greg KH
2025-05-26T12:21:13Z

On Mon, May 26, 2025 at 07:06:54PM +0800, clingfei wrote:
> diff --git a/include/linux/greybus/greybus_protocols.h b/include/linux/greybus/greybus_protocols.h
> index 820134b0105c..14395f9300d6 100644
> --- a/include/linux/greybus/greybus_protocols.h
> +++ b/include/linux/greybus/greybus_protocols.h
> @@ -110,11 +110,6 @@ struct gb_control_get_manifest_size_response {
> __le16 size;
> } __packed;
>
> -/* Control protocol manifest get request has no payload */
> -struct gb_control_get_manifest_response {
> - __u8 data[0];
> -} __packed;
> -
> /* Control protocol [dis]connected request */
> struct gb_control_connected_request {
> __le16 cport_id;
> @@ -678,10 +673,6 @@ struct gb_i2c_transfer_request {
> __le16 op_count;
> struct gb_i2c_transfer_op ops[]; /* op_count of these */
> } __packed;
> -struct gb_i2c_transfer_response {
> - __u8 data[0]; /* inbound data */
> -} __packed;
> -
>
> /* GPIO */
>

Why are you deleting these structures that userspace uses? Are you sure
you can do this? How was this tested?

thanks,

greg k-h