Re: 回复: [PATCH v1 5/7] staging: media: starfive: Add ISP raw video device

Dan Carpenter
2024-03-07T07:55:21Z

On Thu, Mar 07, 2024 at 02:13:50AM +0000, Changhuang Liang wrote:
> Hi, Dan
>
> [...]
> > >
> > > +err_rm_links0:
> > > + media_entity_remove_links(&isp_dev->subdev.entity);
> >
> > I don't think this line is correct. I think we only need to remove
> > &cap_yuv->video.vdev.entity.
> >
>
> The instance I refer to needs to clear both the source entity and the sink entity. See
> https://elixir.bootlin.com/linux/v6.8-rc7/source/drivers/media/platform/verisilicon/hantro_drv.c#L855
>

Oh yeah. It's the same in v4l2_m2m_register_media_controller().

regards,
dan carpenter