回复: [PATCH v1 2/7] staging: media: starfive: Add raw pad for ISP

Changhuang Liang
2024-03-07T02:07:04Z

Hi Dan

> Re: [PATCH v1 2/7] staging: media: starfive: Add raw pad for ISP
>
> On Wed, Mar 06, 2024 at 01:33:29AM -0800, Changhuang Liang wrote:
> > Add raw pad for ISP, it supported the conversion of RAW10 into RAW12.
> >
>
> To be honest, I don't understand what "it supported the conversion of
> RAW10 into RAW12" means. I don't think that this patch has any impact on
> user space but I'm not 100% sure.
>

For StarFive ISP, the input format is RAW 10, which is converted to RAW 12 after ISP RAW pad output.

> A lot of this patch is just reformating stuff and it would be easier to review if
> the reformating were separated into a separate patch.
>
> patch 2: Clean pad selection in isp_try_format()
>
> The code to select isp_dev->formats[] is overly complicated. We can just use
> the "pad" as the index. This will making adding new pads easier in future
> patches. No functional change.
>
> patch 3: Add raw pad for ISP
>

Yes, this patch can also be split into two patches

regards,
Changhuang