Re: [PATCH v1 3/7] staging: media: starfive: Sink rectangle set to ISP source pad

Dan Carpenter
2024-03-06T14:23:55Z

On Wed, Mar 06, 2024 at 01:33:30AM -0800, Changhuang Liang wrote:
> Sink rectangle will be valid for all source pads.
>

This commit message is just really unclear. What does "Sink rectangle
set to ISP source pad" even mean? A better subject would probably be
"staging: media: starfive: Use PAD_SINK instead of PAD_SRC for crop"

But why are we making this change? It's not clear.

regards,
dan carpenter