Re: [PATCH v3 1/8] Staging: sm750fb: Rename sii164ResetChip

[Greg KH <gregkh@linuxfoundation.org>]

On Wed, Mar 06, 2024 at 05:44:51AM +0000, Dorine Tipo wrote:
> Rename variable sii164ResetChip to sii164_reset_chip to silence
> checkpatch warning Avoid CamelCase
> 
> Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>
> ---
> V2: Added the patch to a series.
>     Fixed errors within the patch.
>     Compiled the kernel
> 
> V3: Reverted a commit in the same patch series
> 
>  drivers/staging/sm750fb/ddk750_dvi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/sm750fb/ddk750_dvi.c b/drivers/staging/sm750fb/ddk750_dvi.c
> index 3fb14eff2de1..6dee95e60a6e 100644
> --- a/drivers/staging/sm750fb/ddk750_dvi.c
> +++ b/drivers/staging/sm750fb/ddk750_dvi.c
> @@ -18,7 +18,7 @@ static struct dvi_ctrl_device dcft_supported_dvi_controller[] = {
>  		.get_vendor_id = sii164_get_vendor_id,
>  		.get_device_id = sii164_get_device_id,
>  #ifdef SII164_FULL_FUNCTIONS
> -		.reset_chip = sii164ResetChip,
> +		.reset_chip = sii164_reset_chip,
>  		.get_chip_string = sii164GetChipString,
>  		.set_power = sii164SetPower,
>  		.enable_hot_plug_detection = sii164EnableHotPlugDetection,

You did not compile with this change applied, did you?

If so, can you show us the steps you did?  There still is a function
called sii164ResetChip() in the tree after you apply this commit, and
there is no function called sii164_reset_chip(), right?

confused,

greg k-h