From: Thomas Zimmermann <tzimmermann@suse.de>
To: lee@kernel.org, daniel.thompson@linaro.org, jingoohan1@gmail.com,
deller@gmx.de, andy@kernel.org, geert@linux-m68k.org,
dan.carpenter@linaro.org, sam@ravnborg.org
Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
linux-staging@lists.linux.dev,
Thomas Zimmermann <tzimmermann@suse.de>
Subject: [PATCH v2 5/6] staging: fbtft: Remove reference to fb_blank
Date: Tue, 19 Mar 2024 10:37:24 +0100 [thread overview]
Message-ID: <20240319093915.31778-6-tzimmermann@suse.de> (raw)
In-Reply-To: <20240319093915.31778-1-tzimmermann@suse.de>
The field fb_blank in struct backlight_properties is deprecated and
should not be used. Don't output its value in the driver's debug print.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
---
drivers/staging/fbtft/fb_ssd1351.c | 4 +---
drivers/staging/fbtft/fbtft-core.c | 5 ++---
2 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/fbtft/fb_ssd1351.c b/drivers/staging/fbtft/fb_ssd1351.c
index 72172e870007e..ca2cba2185ae3 100644
--- a/drivers/staging/fbtft/fb_ssd1351.c
+++ b/drivers/staging/fbtft/fb_ssd1351.c
@@ -194,9 +194,7 @@ static int update_onboard_backlight(struct backlight_device *bd)
struct fbtft_par *par = bl_get_data(bd);
bool on;
- fbtft_par_dbg(DEBUG_BACKLIGHT, par,
- "%s: power=%d, fb_blank=%d\n",
- __func__, bd->props.power, bd->props.fb_blank);
+ fbtft_par_dbg(DEBUG_BACKLIGHT, par, "%s: power=%d\n", __func__, bd->props.power);
on = !backlight_is_blank(bd);
/* Onboard backlight connected to GPIO0 on SSD1351, GPIO1 unused */
diff --git a/drivers/staging/fbtft/fbtft-core.c b/drivers/staging/fbtft/fbtft-core.c
index 3626f429b002c..5ca150c409c3c 100644
--- a/drivers/staging/fbtft/fbtft-core.c
+++ b/drivers/staging/fbtft/fbtft-core.c
@@ -133,9 +133,8 @@ static int fbtft_backlight_update_status(struct backlight_device *bd)
struct fbtft_par *par = bl_get_data(bd);
bool polarity = par->polarity;
- fbtft_par_dbg(DEBUG_BACKLIGHT, par,
- "%s: polarity=%d, power=%d, fb_blank=%d\n",
- __func__, polarity, bd->props.power, bd->props.fb_blank);
+ fbtft_par_dbg(DEBUG_BACKLIGHT, par, "%s: polarity=%d, power=%d\n", __func__,
+ polarity, bd->props.power);
if (!backlight_is_blank(bd))
gpiod_set_value(par->gpio.led[0], polarity);
--
2.44.0
next prev parent reply other threads:[~2024-03-19 9:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-19 9:37 [PATCH v2 0/6] backlight: Remove struct backlight_properties.fb_blank Thomas Zimmermann
2024-03-19 9:37 ` [PATCH v2 1/6] auxdisplay: ht16k33: Replace use of fb_blank with backlight helper Thomas Zimmermann
2024-03-19 9:37 ` [PATCH v2 2/6] backlight: omap1: Remove unused struct omap_backlight_config.set_power Thomas Zimmermann
2024-03-19 9:37 ` [PATCH v2 3/6] backlight: omap1: Replace FB_BLANK_ states with simple on/off Thomas Zimmermann
2024-03-19 15:25 ` Daniel Thompson
2024-03-19 9:37 ` [PATCH v2 4/6] fbdev: omap2/omapfb: Replace use of fb_blank with backlight helpers Thomas Zimmermann
2024-03-19 9:37 ` Thomas Zimmermann [this message]
2024-03-22 9:52 ` [PATCH v2 5/6] staging: fbtft: Remove reference to fb_blank Greg KH
2024-03-19 9:37 ` [PATCH v2 6/6] backlight: Remove fb_blank from struct backlight_properties Thomas Zimmermann
2024-03-20 8:46 ` FLAVIO SULIGOI
2024-03-20 8:51 ` Thomas Zimmermann
2024-03-20 9:00 ` EXTERNAL: " FLAVIO SULIGOI
2024-03-21 18:21 ` [PATCH v2 0/6] backlight: Remove struct backlight_properties.fb_blank Lee Jones
2024-03-27 14:40 ` Lee Jones
2024-03-27 14:41 ` Lee Jones
2024-03-28 10:32 ` [GIT PULL] Immutable branch between MFD, Auxdisplay, Staging, fbdev and OMAP due for the v6.9 merge window Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240319093915.31778-6-tzimmermann@suse.de \
--to=tzimmermann@suse.de \
--cc=andy@kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=daniel.thompson@linaro.org \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert@linux-m68k.org \
--cc=jingoohan1@gmail.com \
--cc=lee@kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox