Re: [PATCH v2 0/6] backlight: Remove struct backlight_properties.fb_blank

Lee Jones
2024-03-21T18:21:06Z

On Tue, 19 Mar 2024, Thomas Zimmermann wrote:

> The field fb_blank in struct backlight_properties has been marked for
> removal. Remove it in favor of the power and state fields.
>
> Patches 1 to 5 prepare several backlight drivers. They remove fb_blank
> or replace driver code with existing helpers.
>
> Patch 6 removes fb_blank from backlight core and drivers. This resolves
> another dependency between backlight nad fbdev.
>
> v2:
> - omap1: replace 'power' with 'enable'
> - clarify commit messages
>
> Thomas Zimmermann (6):
> auxdisplay: ht16k33: Replace use of fb_blank with backlight helper
> backlight: omap1: Remove unused struct omap_backlight_config.set_power
> backlight: omap1: Replace FB_BLANK_ states with simple on/off
> fbdev: omap2/omapfb: Replace use of fb_blank with backlight helpers
> staging: fbtft: Remove reference to fb_blank
> backlight: Remove fb_blank from struct backlight_properties
>
> drivers/auxdisplay/ht16k33.c | 7 +--
> drivers/staging/fbtft/fb_ssd1351.c | 4 +-
> drivers/staging/fbtft/fbtft-core.c | 5 +-
> drivers/video/backlight/backlight.c | 2 -
> drivers/video/backlight/mp3309c.c | 1 -
> drivers/video/backlight/omap1_bl.c | 47 +++++++------------
> drivers/video/fbdev/atmel_lcdfb.c | 1 -
> .../omap2/omapfb/displays/panel-dsi-cm.c | 7 +--
> .../omapfb/displays/panel-sony-acx565akm.c | 10 +---
> include/linux/backlight.h | 25 +---------
> include/linux/platform_data/omap1_bl.h | 1 -
> 11 files changed, 26 insertions(+), 84 deletions(-)

Is everyone okay with this being pushed through Backlight?

I can send out a PR to an immutable branch for others to pull from.

--
Lee Jones [李琼斯]