Re: [PATCH RFC 1/7] regulator: devres: add APIs for reference supplies

Jonathan Cameron
2024-03-30T16:03:03Z

On Thu, 28 Mar 2024 20:25:31 +0000
Mark Brown <broonie@kernel.org> wrote:

> On Thu, Mar 28, 2024 at 01:17:52PM -0700, Dmitry Torokhov wrote:
> > On Thu, Mar 28, 2024 at 06:18:32PM +0000, Mark Brown wrote:
>
> > > I don't follow what you're saying here? What normal APIs are not
> > > available? AFAICT this has nothing to do with a devm enable, it's a
> > > combined operation which reports the voltage for the regulator if one is
> > > available which would still be being added even if it used a devm
> > > enable.
>
> > You can not do devm_regulator_get_enable() and then call
> > regulator_get_voltage(), you need a new combined API.
>
> I think the theory here is that there are so many instances of this
> reference voltage pattern that it's useful to have a helper for that
> reason alone.

Exactly that - this is just adding a convenience function to
remove boilerplate. -20ish lines of cut and paste code per
driver.

Jonathan