Re: [PATCH v3 6/7] staging: pi433: Add debugfs_remove in case of driver register fails.

Greg Kroah-Hartman
2024-04-05T10:50:48Z

On Fri, Apr 05, 2024 at 12:42:38PM +0200, Markus Elfring wrote:
> I suggest to use the summary phrase “Call debugfs_remove() in case of
> driver registration failure in pi433_init()” instead.
>
>
> > debugfs resources were never cleaned in case of failure to register driver.
>
> How do you think about to use a change description like the following?
>
> Debugfs resources were not released after a call of
> the function “spi_register_driver” failed.
> Thus fix the exception handling accordingly.
>
>
> Regards,
> Markus
>

Hi,

This is the semi-friendly patch-bot of Greg Kroah-Hartman.

Markus, you seem to have sent a nonsensical or otherwise pointless
review comment to a patch submission on a Linux kernel developer mailing
list. I strongly suggest that you not do this anymore. Please do not
bother developers who are actively working to produce patches and
features with comments that, in the end, are a waste of time.

Patch submitter, please ignore Markus's suggestion; you do not need to
follow it at all. The person/bot/AI that sent it is being ignored by
almost all Linux kernel maintainers for having a persistent pattern of
behavior of producing distracting and pointless commentary, and
inability to adapt to feedback. Please feel free to also ignore emails
from them.

thanks,

greg k-h's patch email bot