From: Greg KH <gregkh@linuxfoundation.org>
To: purofle <purofle@gmail.com>
Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-staging@lists.linux.dev
Subject: Re: [PATCH] staging: fbtft: fb_st7789v: support setting offset
Date: Tue, 9 Apr 2024 17:49:25 +0200 [thread overview]
Message-ID: <2024040935-naturist-skimmer-391f@gregkh> (raw)
In-Reply-To: <20240405165747.93377-1-purofle@gmail.com>
On Sat, Apr 06, 2024 at 12:57:47AM +0800, purofle wrote:
> Some screen sizes using st7789v chips are different from 240x320,
> and offsets need to be set to display all images properly.
>
> Signed-off-by: purofle <purofle@gmail.com>
We need a semi-real name here please.
> ---
> drivers/staging/fbtft/fb_st7789v.c | 22 ++++++++++++++++++++++
> 1 file changed, 22 insertions(+)
>
> diff --git a/drivers/staging/fbtft/fb_st7789v.c b/drivers/staging/fbtft/fb_st7789v.c
> index 861a15414..d47ab4262 100644
> --- a/drivers/staging/fbtft/fb_st7789v.c
> +++ b/drivers/staging/fbtft/fb_st7789v.c
> @@ -30,6 +30,12 @@
>
> #define HSD20_IPS 1
>
> +#define WIDTH 240
> +#define HEIGHT 320
So you are now hard-coding the size?
> +
> +#define LEFT_OFFSET 0
> +#define TOP_OFFSET 0
Is this always going to be 0, if so, why need it at all?
thanks,
greg k-h
next prev parent reply other threads:[~2024-04-09 15:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-05 16:57 [PATCH] staging: fbtft: fb_st7789v: support setting offset purofle
2024-04-09 15:49 ` Greg KH [this message]
2024-04-09 17:28 ` Yuguo Pei
2024-04-09 17:36 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2024-04-09 16:39 purofle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024040935-naturist-skimmer-391f@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=purofle@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox