From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CCAE417722; Sat, 6 Jul 2024 11:41:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720266113; cv=none; b=FGyObo6At4fR9rZa8U8jQSn5WDBNQZovWFFvGzZj+dOgMfhGF2DLATDqirmxZeEjj8lIQMSlglzUXSaKmI5tOrBlRTUf+5QZML3wVCUkhWXqXwRq8ahNJRwfJ5TGFExnmrtLFHHd/5+YUaokUkGKww2E6lK6BtecVhg/319vSjE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720266113; c=relaxed/simple; bh=ZpiVxTkDAGl22bjAArHNJMuQ2aUZXYATBN98gMUP21o=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=seH+fK8+/3YRavF2FhxJuUtzkIsZlyRY+IOyNptssQlWHL4F32Egced8+VtLt4bM6J6B9EeyntLIZx/Hlvd65q7ZjNc8HAg/AyKxigaFNLf9A6YvpXbvd6nTbiD+HK+tymfZ99f2YCjPmwONSq0kEZuh5HdSmNWvStpZRXWi4Kc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=pdbVrXBM; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="pdbVrXBM" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 49B5CC3277B; Sat, 6 Jul 2024 11:41:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1720266113; bh=ZpiVxTkDAGl22bjAArHNJMuQ2aUZXYATBN98gMUP21o=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=pdbVrXBMMhrkNbPlOYhoopbfyJZKXKB7YfADm1W4wkui0/I0wSjo+olFCsab1Eq49 CUPuhVMV/weIvaJwy+S45vFVEouTkc5c/yMdtq3WzO2bhDpYuQHrYnov/ArFFLWucA FDOu4lk3VM57dcQaPwXoMIfSQR9b19FvAmoJWqxGdN9zaBh9OKgxv9zm+ReHpTmeKA Z/jsHtxUKg8+q0PcGbxEcj2BpSYr0Q+HVxJpsdhwpvJ+AEi++AC5QVZHvmvOmekWq7 ZHHxuL3Hn0JfbFUTrDP62xwihhbonXFMHtgtUoZwyrIEKPSC4Z2zhmuZg8N4bFyPo8 dxKj4EKuBlqhQ== Date: Sat, 6 Jul 2024 12:41:46 +0100 From: Jonathan Cameron To: Dan Carpenter Cc: Aleksandr Mishin , Michael Hennerich , Lars-Peter Clausen , Greg Kroah-Hartman , Datta Shubhrajyoti , linux-iio@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org Subject: Re: [PATCH v2] staging: iio: frequency: ad9834: Validate frequency parameter value Message-ID: <20240706124146.036f152a@jic23-huawei> In-Reply-To: <59cc60a1-f6d6-4f9f-bc36-6b06315eaee4@suswa.mountain> References: <20240703104734.12034-1-amishin@t-argos.ru> <20240703154506.25584-1-amishin@t-argos.ru> <59cc60a1-f6d6-4f9f-bc36-6b06315eaee4@suswa.mountain> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 3 Jul 2024 18:29:43 +0200 Dan Carpenter wrote: > On Wed, Jul 03, 2024 at 06:45:06PM +0300, Aleksandr Mishin wrote: > > In ad9834_write_frequency() clk_get_rate() can return 0. In such case > > ad9834_calc_freqreg() call will lead to division by zero. Checking > > 'if (fout > (clk_freq / 2))' doesn't protect in case of 'fout' is 0. > > ad9834_write_frequency() is called from ad9834_write(), where fout is > > taken from text buffer, which can contain any value. > > > > Modify parameters checking. > > > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > > > Fixes: 12b9d5bf76bf ("Staging: IIO: DDS: AD9833 / AD9834 driver") > > Suggested-by: Dan Carpenter > > Signed-off-by: Aleksandr Mishin > > --- > > v1->v2: Check if clk_freq == 0 directly instead of fout == 0 > > as suggested by Dan > > > Thanks! > > Reviewed-by: Dan Carpenter > Applied and marked for stable. > regards, > dan carpenter >