Linux kernel staging patches
 help / color / mirror / Atom feed
From: Agathe Porte <gagath@debian.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev
Cc: ~lkcamp/patches@lists.sr.ht, helen.koike@collabora.com
Subject: [PATCH] staging: vme_user: vme_irq_handler: name func ptr args
Date: Tue, 30 Jul 2024 15:27:54 +0900	[thread overview]
Message-ID: <20240730062843.64977-1-gagath@debian.org> (raw)

This commit fixes the following checkpatch.pl warnings:

WARNING: function definition argument 'int' should also have an identifier name
+	void (*call)(int, int, void *);

WARNING: function definition argument 'int' should also have an identifier name
+	void (*call)(int, int, void *);

WARNING: function definition argument 'void *' should also have an identifier name
+	void (*call)(int, int, void *);

Signed-off-by: Agathe Porte <gagath@debian.org>

---

This is my first contribution to staging to test if my setup works
well and helping improve a staging driver while at it.

 drivers/staging/vme_user/vme.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/vme_user/vme.c b/drivers/staging/vme_user/vme.c
index 9a0914636..218b19db6 100644
--- a/drivers/staging/vme_user/vme.c
+++ b/drivers/staging/vme_user/vme.c
@@ -1265,7 +1265,7 @@ EXPORT_SYMBOL(vme_unregister_error_handler);
 
 void vme_irq_handler(struct vme_bridge *bridge, int level, int statid)
 {
-	void (*call)(int, int, void *);
+	void (*call)(int level, int statid, void *priv_data);
 	void *priv_data;
 
 	call = bridge->irq[level - 1].callback[statid].func;
-- 
2.43.0


                 reply	other threads:[~2024-07-30  6:28 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240730062843.64977-1-gagath@debian.org \
    --to=gagath@debian.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=helen.koike@collabora.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=~lkcamp/patches@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox