From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D0701B29A7; Wed, 31 Jul 2024 16:10:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722442241; cv=none; b=JjT8kEqTmQR2qYYY34wKQPlzorVmLr3+3vmWaWA2xoEGTdn37DUFh1jIsB2BU+LLEWf5wFhcDkXvum4tXc2NOYXzCl3uR3na3mXM9PvG7vKJxiQYHK65uUYj+3rj78+LZ5sFBXV9PLIpXSbAST6JjDlXWzbmE7etFfJDRkKOMJE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722442241; c=relaxed/simple; bh=VeBZHTZ9MWthhdznTxC81hf76FdhTqXK3UXAPLv2cyE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JXGE/wwg/KbUVVRKLQIW33LjigtUusDV2WJGw9SESroImoGfJYY5iwvUC1pQzjYPvyjkZpLHPgjR1M7jp4rKT8LfqWXPhFsLOK/yS3DPAdtkahIEL0zv+XliRn6JtjIQcVrGbdTDl2Lbkc69mkH+zf9uWUlnavAWkoAAjYESYHo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=DCqv1JvG; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="DCqv1JvG" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8B283C116B1; Wed, 31 Jul 2024 16:10:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1722442240; bh=VeBZHTZ9MWthhdznTxC81hf76FdhTqXK3UXAPLv2cyE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DCqv1JvGal0RNE82tOEkNwOb7cQBjQzbhORx8zYX1wTBiy3Q3bwZxXToxkwwKsyfz N385rDmnYB/SfTd8gS8U3r18Sp/dI7TvSQ9sms7P8oosaqHYqE9yCqgbcCkAB6LdrM vWuu91/7L++WoZTcUjbOQtDpT8iXT5CTLdfUW9oA= Date: Wed, 31 Jul 2024 18:10:38 +0200 From: Greg Kroah-Hartman To: EiPiFun Cc: linux-staging , linux-kernel Subject: Re: [PATCH] code indent, drivers/staging/rtl8723bs/include/rtw_security.h Message-ID: <2024073104-friction-conjoined-c34a@gregkh> References: Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Aug 01, 2024 at 12:52:54AM +0900, EiPiFun wrote: > From 816921cbfa76a1cfd0cb1ca93a9df0f2a429bc3a Mon Sep 17 00:00:00 2001 > From: EiPi Fun Date: Tue, 30 Jul 2024 07:28:38 +0000 > Subject: [PATCH] code indent should use tabs where possible > > --- >  drivers/staging/rtl8723bs/include/rtw_security.h | 4 ++-- >  1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/rtl8723bs/include/rtw_security.h > b/drivers/staging/rtl8723bs/include/rtw_security.h > index c3e47d526..89c1d5ae1 100644 > --- a/drivers/staging/rtl8723bs/include/rtw_security.h > +++ b/drivers/staging/rtl8723bs/include/rtw_security.h > @@ -75,8 +75,8 @@ struct { >  }; >   >  union Keytype { > -        u8   skey[16]; > -        u32    lkey[4]; > + u8   skey[16]; > + u32    lkey[4]; >  }; >   >   > -- > 2.20.1 Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - Your patch is malformed (tabs converted to spaces, linewrapped, etc.) and can not be applied. Please read the file, Documentation/process/email-clients.rst in order to fix this. - Your patch was attached, please place it inline so that it can be applied directly from the email message itself. - Your patch does not have a Signed-off-by: line. Please read the kernel file, Documentation/process/submitting-patches.rst and resend it after adding that line. Note, the line needs to be in the body of the email, before the patch, not at the bottom of the patch or in the email signature. - You did not specify a description of why the patch is needed, or possibly, any description at all, in the email body. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/process/submitting-patches.rst for what is needed in order to properly describe the change. - You did not write a descriptive Subject: for the patch, allowing Greg, and everyone else, to know what this patch is all about. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/process/submitting-patches.rst for what a proper Subject: line should look like. - It looks like you did not use your name for the patch on either the Signed-off-by: line, or the From: line (both of which have to match). Please read the kernel file, Documentation/process/submitting-patches.rst for how to do this correctly. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot