From: Manjae Cho <manjae.cho@samsung.com>
To: gregkh@linuxfoundation.org
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Manjae Cho <manjae.cho@samsung.com>
Subject: [PATCH] staging: rtl8723bs: Improve MAR register definition and usage
Date: Wed, 31 Jul 2024 14:36:21 +0900 [thread overview]
Message-ID: <20240731053620.783572-1-manjae.cho@samsung.com> (raw)
In-Reply-To: CGME20240731053636epcas1p45b75f5d5256ba9360feda929d04a0106@epcas1p4.samsung.com
This patch improves the usage of the MAR register by updating the
relevant
macro definitions and ensuring consistent usage across the codebase.
Signed-off-by: Manjae Cho <manjae.cho@samsung.com>
---
drivers/staging/rtl8723bs/hal/sdio_halinit.c | 4 ++--
drivers/staging/rtl8723bs/include/hal_com_reg.h | 3 +++
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
index c9cd6578f7f8..9493562c1619 100644
--- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c
+++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
@@ -380,8 +380,8 @@ static void _InitWMACSetting(struct adapter *padapter)
rtw_write32(padapter, REG_RCR, pHalData->ReceiveConfig);
/* Accept all multicast address */
- rtw_write32(padapter, REG_MAR, 0xFFFFFFFF);
- rtw_write32(padapter, REG_MAR + 4, 0xFFFFFFFF);
+ rtw_write32(padapter, MAR0, 0xFFFFFFFF);
+ rtw_write32(padapter, MAR4, 0xFFFFFFFF);
/* Accept all data frames */
value16 = 0xFFFF;
diff --git a/drivers/staging/rtl8723bs/include/hal_com_reg.h b/drivers/staging/rtl8723bs/include/hal_com_reg.h
index 9a02ae69d7a4..baf326d53a46 100644
--- a/drivers/staging/rtl8723bs/include/hal_com_reg.h
+++ b/drivers/staging/rtl8723bs/include/hal_com_reg.h
@@ -151,6 +151,9 @@
#define REG_BSSID 0x0618
#define REG_MAR 0x0620
+#define MAR0 REG_MAR /* Multicast Address Register, Offset 0x0620-0x0623 */
+#define MAR4 (REG_MAR + 4) /* Multicast Address Register, Offset 0x0624-0x0627 */
+
#define REG_MAC_SPEC_SIFS 0x063A
/* 20100719 Joseph: Hardware register definition change. (HW datasheet v54) */
#define REG_RESP_SIFS_CCK 0x063C /* [15:8]SIFS_R2T_OFDM, [7:0]SIFS_R2T_CCK */
--
2.25.1
next parent reply other threads:[~2024-07-31 5:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20240731053636epcas1p45b75f5d5256ba9360feda929d04a0106@epcas1p4.samsung.com>
2024-07-31 5:36 ` Manjae Cho [this message]
2024-07-31 5:48 ` [PATCH] staging: rtl8723bs: Improve MAR register definition and usage Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240731053620.783572-1-manjae.cho@samsung.com \
--to=manjae.cho@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox