* [PATCH] staging: rtl8192e: Fix alignment parenthesis
@ 2024-08-22 0:27 Nilo Alexandre
2024-08-22 7:52 ` Greg Kroah-Hartman
0 siblings, 1 reply; 2+ messages in thread
From: Nilo Alexandre @ 2024-08-22 0:27 UTC (permalink / raw)
To: Greg Kroah-Hartman, linux-staging, linux-kernel, ~lkcamp/patches
Fix alignment parenthesis in _rtl92e_read_eeprom_info
CHECK: Alignment should match open parenthesis
Signed-off-by: Nilo Alexandre <n1lux.comp@gmail.com>
---
drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
index d95807ceed7a6..caaa79935d7da 100644
--- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
+++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
@@ -322,7 +322,7 @@ static void _rtl92e_read_eeprom_info(struct net_device *dev)
if (priv->epromtype == EEPROM_93C46) {
if (!priv->autoload_fail_flag) {
usValue = rtl92e_eeprom_read(dev,
- EEPROM_TxPwDiff_CrystalCap >> 1);
+ EEPROM_TxPwDiff_CrystalCap >> 1);
priv->eeprom_ant_pwr_diff = usValue & 0x0fff;
priv->eeprom_crystal_cap = (usValue & 0xf000)
>> 12;
--
2.46.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: rtl8192e: Fix alignment parenthesis
2024-08-22 0:27 [PATCH] staging: rtl8192e: Fix alignment parenthesis Nilo Alexandre
@ 2024-08-22 7:52 ` Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2024-08-22 7:52 UTC (permalink / raw)
To: Nilo Alexandre; +Cc: linux-staging, linux-kernel, ~lkcamp/patches
On Wed, Aug 21, 2024 at 09:27:00PM -0300, Nilo Alexandre wrote:
> Fix alignment parenthesis in _rtl92e_read_eeprom_info
>
> CHECK: Alignment should match open parenthesis
>
> Signed-off-by: Nilo Alexandre <n1lux.comp@gmail.com>
> ---
> drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
> index d95807ceed7a6..caaa79935d7da 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
> +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
> @@ -322,7 +322,7 @@ static void _rtl92e_read_eeprom_info(struct net_device *dev)
> if (priv->epromtype == EEPROM_93C46) {
> if (!priv->autoload_fail_flag) {
> usValue = rtl92e_eeprom_read(dev,
> - EEPROM_TxPwDiff_CrystalCap >> 1);
> + EEPROM_TxPwDiff_CrystalCap >> 1);
The alignment DID match, you just need to use tabs instead of spaces.
Did you run this change through checkpatch.pl after making it to verify
it did what you are saying it did?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-08-22 7:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-22 0:27 [PATCH] staging: rtl8192e: Fix alignment parenthesis Nilo Alexandre
2024-08-22 7:52 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).