Linux kernel staging patches
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Gabriel Maciel Raad <ffunctor@gmail.com>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
	~lkcamp/patches@lists.sr.ht
Subject: Re: [PATCH] Staging: rtl8192e: Fix parenthesis alignment
Date: Thu, 22 Aug 2024 15:49:28 +0800	[thread overview]
Message-ID: <2024082253-duration-esteemed-a057@gregkh> (raw)
In-Reply-To: <20240822002346.3555-1-ffunctor@gmail.com>

On Wed, Aug 21, 2024 at 09:23:43PM -0300, Gabriel Maciel Raad wrote:
> Fix parenthesis alignment and unnecessary blank line in
> rtl92e_leisure_ps_enter to fix the following checkpatch.pl warnings:
> 
> CHECK: Alignment should match open parenthesis
> CHECK: Blank lines aren't necessary after an open brace '{'

You did two different things here (and one was not mentioned in the
subject line.)

Always do one "logical thing" per patch, this should be split up into 2
different onces.

thanks,

greg k-h

  reply	other threads:[~2024-08-22  7:49 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-22  0:23 [PATCH] Staging: rtl8192e: Fix parenthesis alignment Gabriel Maciel Raad
2024-08-22  7:49 ` Greg Kroah-Hartman [this message]
  -- strict thread matches above, loose matches on Subject: below --
2024-08-24 14:43 [PATCH] staging: " Gabriel Tassinari
2024-08-26  1:17 ` Philipp Hortmann
2024-08-22  9:10 Dan Carpenter
2024-08-22  0:45 Túlio Fernandes
2024-08-22  0:26 Pedro Orlando
2024-08-22  0:26 [PATCH] staging: rtl8192e: fix " Christian S Lima
2024-08-22  0:25 [PATCH] staging: rtl8192e: Fix " Leonardo Kenji
2024-08-22  0:23 Vinicius Peixoto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2024082253-duration-esteemed-a057@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=ffunctor@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=~lkcamp/patches@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox