From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7BCA91799B for ; Sun, 25 Aug 2024 07:31:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724571070; cv=none; b=eQ3oLzoNOZ1LMGmfmTC1oVNXGnCPAMzVF6zlv7qPtuD7BrfP2qWMi2tEQR8FU6RXJCDf3JjD7wgHuppGZA3IXYMY+kocZ04JsAwWE/HFqkvTPsIBKeEs79LqNnAVwZef2E/XzmJVf96lrFbGTooxEPLw4GKLZDyskXDA5rKuF7U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724571070; c=relaxed/simple; bh=hoNuMWYxkglcTbbg0GqNeZkJrv+ll78JOQKbQTS/5ak=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=rIHb9hsLTiKsfN0B9OBGakS2cC6dcVpkrFqQr6pFvNZpsYjq80p3Vz31HOae5noqiA/z6AbPsi3N7TrXIRaE7cWnR61mg2iABFVR4ogl1Tj14Ow8mIuxjfJR8MK1M849fm8msETs3O3FrJfI2/Sj+A//1O9CLk2nVoUJGWMr2eA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PMuUBNgv; arc=none smtp.client-ip=209.85.210.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PMuUBNgv" Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-7142448aaf9so2225560b3a.1 for ; Sun, 25 Aug 2024 00:31:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724571068; x=1725175868; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Ts7yizrblkO4nvNk46I7HF9q9zW3lz7Ntet34lL3n2M=; b=PMuUBNgvPoKSc07uHi+wMk9u+xv83awNkZQjoR5FBfmJtEfZl/dPZton+r7DnlKgPg iCTRXWzRjhImQZHJaxqlfVRw2t9g847W4xwNPUaYPLYfUAzygTTogOJ8w8UMGYBSFnc1 nqsrbpH0GWrUkystD8XYrzaqi0okYu43jd/dw5pVuIxj92tRTk5hgDHer8j4QiQUTxtG P6Ui+EFpgrMcvWv/sSkQU1i0WUUA0/m6CrCGARW0KVPTdTC5anwdYVTNK4WCkH9DMK6k 42g5IAvBDWogNGyfNWh+b7sL6SG6bG2uZUCWCKETny81gh4tusKSLifzp4L7f2jvZptm fE1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724571068; x=1725175868; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Ts7yizrblkO4nvNk46I7HF9q9zW3lz7Ntet34lL3n2M=; b=TFPhcl6F3NiVzhPf2E2IPVA1sugrNUFvtq9FyriuGczXQYraXgR4a42TjoNAZ5nh1R SF1cSfOdbSoX99zdgkgCSGaBImk+LnJiUySMVv20HdddwkPW/ifWwl2tzR7PmuaZPryz XQ0iJe3q+U76j6GtFEqImXJy0TfYwgFBTM10rudrEtSai6N7+iJd2P+Onjsvy/Axqdu4 oK1bUjyRg/Dj5r3Furac9GTFtvWSKGsYqN77KXup9uDOW2KQGBBqwZNnq3yC8YEuMXMl DfNwQAHpJ+F/+px4C6jIUOJnWgpXNgD8ZEnFofU8dr8tRlMsigEcehBMbuOFiGhmrnH5 wcfQ== X-Forwarded-Encrypted: i=1; AJvYcCU6SpZjRZWcNPTq9IoAAdYha95ENCtElo8VvL8kg1PYxpOlJi+6MGWCjHFk3oQHZRSEMwWaygLYyBKkynrk@lists.linux.dev X-Gm-Message-State: AOJu0YxWgrsqY9uKyqOTtVvCdvbU9SuSr2xtRbd6rvMZ3GPseN0MASv/ tK3KC3nBgL1u7QqGUm5KkbGhcUXRJjjiE6e2ONL6WNCwkD1ERK+iN8W0TRfrcX0= X-Google-Smtp-Source: AGHT+IH7lU3KoQ/SeTlBO6d1KhFa8NQOHP+IDt/nph6Xawu52Eo9pLZ7BB6ZhUz7C4miDDYBfynzAA== X-Received: by 2002:a05:6a21:4d81:b0:1c4:85a2:9958 with SMTP id adf61e73a8af0-1cc8a0804bamr11150477637.25.1724571068314; Sun, 25 Aug 2024 00:31:08 -0700 (PDT) Received: from fedora.. ([122.180.191.78]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-714351aee05sm5386041b3a.91.2024.08.25.00.31.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 25 Aug 2024 00:31:07 -0700 (PDT) From: Riyan Dhiman To: gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, Riyan Dhiman Subject: [PATCH] staging: vme_user: Change slot number type from int to u32 Date: Sun, 25 Aug 2024 12:59:55 +0530 Message-ID: <20240825072955.120884-1-riyandhiman14@gmail.com> X-Mailer: git-send-email 2.46.0 Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Change the type used for VME slot numbers from int to u32 throughout vme driver. This modification more accurately represents the nature of slot numbers which are always non-negative. The changes include - Updating variable declarations - Modifying function signatures and return types This change imporves type safety, prevents potential issues with sign conversion. Signed-off-by: Riyan Dhiman --- drivers/staging/vme_user/vme.c | 2 +- drivers/staging/vme_user/vme.h | 4 ++-- drivers/staging/vme_user/vme_bridge.h | 2 +- drivers/staging/vme_user/vme_fake.c | 2 +- drivers/staging/vme_user/vme_tsi148.c | 4 ++-- drivers/staging/vme_user/vme_user.c | 2 +- 6 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/vme_user/vme.c b/drivers/staging/vme_user/vme.c index 42304c9f83a2..aa3be2d7248d 100644 --- a/drivers/staging/vme_user/vme.c +++ b/drivers/staging/vme_user/vme.c @@ -1696,7 +1696,7 @@ EXPORT_SYMBOL(vme_lm_free); * or the function is not supported. Hardware specific errors may also * be returned. */ -int vme_slot_num(struct vme_dev *vdev) +u32 vme_slot_num(struct vme_dev *vdev) { struct vme_bridge *bridge; diff --git a/drivers/staging/vme_user/vme.h b/drivers/staging/vme_user/vme.h index 7753e736f9fd..66388767b6c7 100644 --- a/drivers/staging/vme_user/vme.h +++ b/drivers/staging/vme_user/vme.h @@ -102,7 +102,7 @@ extern const struct bus_type vme_bus_type; * @bridge_list: List of devices (per bridge) */ struct vme_dev { - int num; + u32 num; struct vme_bridge *bridge; struct device dev; struct list_head drv_list; @@ -179,7 +179,7 @@ int vme_lm_attach(struct vme_resource *, int, void (*callback)(void *), void *); int vme_lm_detach(struct vme_resource *, int); void vme_lm_free(struct vme_resource *); -int vme_slot_num(struct vme_dev *); +u32 vme_slot_num(struct vme_dev *); int vme_bus_num(struct vme_dev *); int vme_register_driver(struct vme_driver *, unsigned int); diff --git a/drivers/staging/vme_user/vme_bridge.h b/drivers/staging/vme_user/vme_bridge.h index 9bdc41bb6602..6778447eadfb 100644 --- a/drivers/staging/vme_user/vme_bridge.h +++ b/drivers/staging/vme_user/vme_bridge.h @@ -160,7 +160,7 @@ struct vme_bridge { int (*lm_detach)(struct vme_lm_resource *, int); /* CR/CSR space functions */ - int (*slot_get)(struct vme_bridge *); + u32 (*slot_get)(struct vme_bridge *); /* Bridge parent interface */ void *(*alloc_consistent)(struct device *dev, size_t size, dma_addr_t *dma); diff --git a/drivers/staging/vme_user/vme_fake.c b/drivers/staging/vme_user/vme_fake.c index 7f84d1c86f29..81601bfa4155 100644 --- a/drivers/staging/vme_user/vme_fake.c +++ b/drivers/staging/vme_user/vme_fake.c @@ -987,7 +987,7 @@ static int fake_lm_detach(struct vme_lm_resource *lm, int monitor) /* * Determine Geographical Addressing */ -static int fake_slot_get(struct vme_bridge *fake_bridge) +static u32 fake_slot_get(struct vme_bridge *fake_bridge) { return geoid; } diff --git a/drivers/staging/vme_user/vme_tsi148.c b/drivers/staging/vme_user/vme_tsi148.c index d81be8e4ceba..65237fb12466 100644 --- a/drivers/staging/vme_user/vme_tsi148.c +++ b/drivers/staging/vme_user/vme_tsi148.c @@ -2109,7 +2109,7 @@ static int tsi148_lm_detach(struct vme_lm_resource *lm, int monitor) /* * Determine Geographical Addressing */ -static int tsi148_slot_get(struct vme_bridge *tsi148_bridge) +static u32 tsi148_slot_get(struct vme_bridge *tsi148_bridge) { u32 slot = 0; struct tsi148_driver *bridge; @@ -2123,7 +2123,7 @@ static int tsi148_slot_get(struct vme_bridge *tsi148_bridge) slot = geoid; } - return (int)slot; + return slot; } static void *tsi148_alloc_consistent(struct device *parent, size_t size, diff --git a/drivers/staging/vme_user/vme_user.c b/drivers/staging/vme_user/vme_user.c index 5829a4141561..63f8efc19324 100644 --- a/drivers/staging/vme_user/vme_user.c +++ b/drivers/staging/vme_user/vme_user.c @@ -506,7 +506,7 @@ static int vme_user_match(struct vme_dev *vdev) int i; int cur_bus = vme_bus_num(vdev); - int cur_slot = vme_slot_num(vdev); + u32 cur_slot = vme_slot_num(vdev); for (i = 0; i < bus_num; i++) if ((cur_bus == bus[i]) && (cur_slot == vdev->num)) -- 2.46.0