From: Nam Cao <namcao@linutronix.de>
To: Riyan Dhiman <riyandhiman14@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
linux-staging@lists.linux.dev
Subject: Re: [PATCH] staging: vme_user: Added static to image_desc and vme_user_vma_priv struct
Date: Sun, 25 Aug 2024 10:13:02 +0200 [thread overview]
Message-ID: <20240825081302.qBkqUqoK@linutronix.de> (raw)
In-Reply-To: <20240825035514.40095-1-riyandhiman14@gmail.com>
On Sun, Aug 25, 2024 at 09:25:14AM +0530, Riyan Dhiman wrote:
> struct image_desc and vme_user_vma_priv are used only in vme_user.c file.
> Added keyword static to these struct definition to limit its scope and
> potentially allow for compiler optimizations.
I'm not sure if there is any optimization that compilers can do, when we
tell it that the struct definitions are local.
Did Gcc not complain when you compile this patch? Because it did for me..
Best regards,
Nam
next prev parent reply other threads:[~2024-08-25 8:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-25 3:55 [PATCH] staging: vme_user: Added static to image_desc and vme_user_vma_priv struct Riyan Dhiman
2024-08-25 8:13 ` Nam Cao [this message]
2024-08-26 22:17 ` kernel test robot
2024-08-26 22:38 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240825081302.qBkqUqoK@linutronix.de \
--to=namcao@linutronix.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=riyandhiman14@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox