Linux kernel staging patches
 help / color / mirror / Atom feed
From: Manisha Singh <masingh.linux@gmail.com>
To: florian.c.schilhabel@googlemail.com, gregkh@linuxfoundation.org,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Cc: Manisha Singh <masingh.linux@gmail.com>
Subject: [PATCH] staging: rtl8712: Fix style issues in rtl871x_io.c
Date: Tue, 27 Aug 2024 00:22:13 +0530	[thread overview]
Message-ID: <20240826185213.9445-2-masingh.linux@gmail.com> (raw)

This patch addresses style issues reported by checkpatch.pl in
drivers/staging/rtl8712/rtl871x_io.c:

1. Avoid Multiple Assignments: The original line had multiple
   assignments in a single statement. This is generally discouraged
   for clarity and maintainability. The code has been refactored to
   use separate statements for each assignment.

2. Prefer `sizeof(*pintf_hdl->pintfpriv)` Over
   `sizeof(struct intf_priv)`: Updated the memory allocation call to
   use `sizeof(*pintf_hdl->pintfpriv)` instead of
   `sizeof(struct intf_priv)`. This is considered better practice as it
   automatically adjusts if the type of `pintf_hdl->pintfpriv` changes,
   reducing the risk of mismatches and improving maintainability.

Changes made:
- Replaced the original line with two separate lines for allocation and
  assignment.
- Updated `kmalloc` to use `sizeof(*pintf_hdl->pintfpriv)` for the
  allocation size.

These changes improve code readability and maintain consistency with
coding standards.

Signed-off-by: Manisha Singh <masingh.linux@gmail.com>
---
 drivers/staging/rtl8712/rtl871x_io.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8712/rtl871x_io.c b/drivers/staging/rtl8712/rtl871x_io.c
index 6789a4c98564..b81e9b06725c 100644
--- a/drivers/staging/rtl8712/rtl871x_io.c
+++ b/drivers/staging/rtl8712/rtl871x_io.c
@@ -48,8 +48,8 @@ static uint _init_intf_hdl(struct _adapter *padapter,
 	set_intf_funs = &(r8712_usb_set_intf_funs);
 	set_intf_ops = &r8712_usb_set_intf_ops;
 	init_intf_priv = &r8712_usb_init_intf_priv;
-	pintf_priv = pintf_hdl->pintfpriv = kmalloc(sizeof(struct intf_priv),
-						    GFP_ATOMIC);
+	pintf_priv = kmalloc(sizeof(*pintf_hdl->pintfpriv), GFP_ATOMIC);
+	pintf_hdl->pintfpriv = pintf_priv;
 	if (!pintf_priv)
 		goto _init_intf_hdl_fail;
 	pintf_hdl->adapter = (u8 *)padapter;
-- 
2.43.0


             reply	other threads:[~2024-08-26 18:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-26 18:52 Manisha Singh [this message]
2024-08-26 19:07 ` [PATCH] staging: rtl8712: Fix style issues in rtl871x_io.c Philipp Hortmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240826185213.9445-2-masingh.linux@gmail.com \
    --to=masingh.linux@gmail.com \
    --cc=florian.c.schilhabel@googlemail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox