Linux kernel staging patches
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Cc: "Dominik Karol Piątkowski"
	<dominik.karol.piatkowski@protonmail.com>,
	tdavies@darkphysics.net, dan.carpenter@linaro.org,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] staging: rtl8192e: Use MSR_LINK_* macros
Date: Wed, 9 Oct 2024 11:53:51 +0200	[thread overview]
Message-ID: <2024100944-baton-manger-3768@gregkh> (raw)
In-Reply-To: <9bb46e16-eb37-4d76-a917-e0f1e738fd04@gmail.com>

On Sun, Sep 22, 2024 at 09:01:09PM +0200, Philipp Hortmann wrote:
> On 9/21/24 2:22 PM, Dominik Karol Piątkowski wrote:
> > There were two seemingly not used macros defined in r8192E_hw.h:
> > MSR_LINK_ADHOC and MSR_LINK_MASTER.
> > 
> > There is one function explicitly updating MSR (Media Status Register):
> > _rtl92e_update_msr - only MSR_LINK_MASK and MSR_LINK_MANAGED are used
> > there. However, in rtl92e_set_reg, inside HW_VAR_MEDIA_STATUS section,
> > MSR is also updated - covering more than MSR_LINK_MANAGED case.
> > 
> > This series makes use of appropriate MSR_LINK_* macros in rtl92e_set_reg
> > and removes duplicated MSR_* macros. While at it, fix camel case variable
> > in rtl92e_set_reg function.
> > 
> > Signed-off-by: Dominik Karol Piątkowski <dominik.karol.piatkowski@protonmail.com>
> > 
> > Dominik Karol Piątkowski (2):
> >    staging: rtl8192e: Use MSR_LINK_* macros
> >    staging: rtl8192e: r8192E_dev.c: Rename btMsr variable
> > 
> >   drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 14 +++++++-------
> >   drivers/staging/rtl8192e/rtl8192e/r8192E_hw.h  |  6 +-----
> >   2 files changed, 8 insertions(+), 12 deletions(-)
> > 
> 
> Reviewed-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
> 

This driver is now deleted from the tree, sorry.

greg k-h

      reply	other threads:[~2024-10-09  9:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-21 12:22 [PATCH 0/2] staging: rtl8192e: Use MSR_LINK_* macros Dominik Karol Piątkowski
2024-09-21 12:22 ` [PATCH 1/2] " Dominik Karol Piątkowski
2024-09-21 12:22 ` [PATCH 2/2] staging: rtl8192e: r8192E_dev.c: Rename btMsr variable Dominik Karol Piątkowski
2024-09-22 19:01 ` [PATCH 0/2] staging: rtl8192e: Use MSR_LINK_* macros Philipp Hortmann
2024-10-09  9:53   ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2024100944-baton-manger-3768@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=dan.carpenter@linaro.org \
    --cc=dominik.karol.piatkowski@protonmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=philipp.g.hortmann@gmail.com \
    --cc=tdavies@darkphysics.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox