From: Greg KH <gregkh@linuxfoundation.org>
To: Aymen Khalfa <a.khalfa.1012@gmail.com>
Cc: hdegoede@redhat.com, Larry.Finger@lwfinger.net,
linux-staging@lists.linux.dev
Subject: Re: [PATCH] drivers: staging: rtl8723bs: Replace msleep() with usleep_range().
Date: Wed, 16 Oct 2024 14:29:33 +0200 [thread overview]
Message-ID: <2024101607-ditzy-magical-5683@gregkh> (raw)
In-Reply-To: <20241016111210.2469193-1-a.khalfa.1012@gmail.com>
On Wed, Oct 16, 2024 at 01:12:10PM +0200, Aymen Khalfa wrote:
> -Fix checkpatch.pl warning by replacing msleep() with usleep_range() as
> recommended in the documentation.
>
> Signed-off-by: Aymen Khalfa <a.khalfa.1012@gmail.com>
> ---
> drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
> index dbfcbac3d855..26e125f556e9 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
> @@ -429,7 +429,7 @@ s32 LPS_RF_ON_check(struct adapter *padapter, u32 delay_ms)
> err = -1;
> break;
> }
> - msleep(1);
> + usleep_range(1000, 2000);
> }
>
> return err;
> @@ -591,7 +591,7 @@ void LPS_Leave_check(struct adapter *padapter)
> if (jiffies_to_msecs(jiffies - start_time) > 100)
> break;
>
> - msleep(1);
> + usleep_range(1000, 2000);
> }
> }
>
> --
> 2.34.1
>
>
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that has triggered this response. He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created. Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.
You are receiving this message because of the following common error(s)
as indicated below:
- You sent a patch that has been sent multiple times in the past, and is
identical to ones that have been rejected. Please always look at the
mailing list traffic to determine if you are duplicating other
people's work.
If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.
thanks,
greg k-h's patch email bot
next prev parent reply other threads:[~2024-10-16 12:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-16 11:12 [PATCH] drivers: staging: rtl8723bs: Replace msleep() with usleep_range() Aymen Khalfa
2024-10-16 11:13 ` Hans de Goede
2024-10-16 12:29 ` Greg KH [this message]
2024-10-16 12:30 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024101607-ditzy-magical-5683@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=Larry.Finger@lwfinger.net \
--cc=a.khalfa.1012@gmail.com \
--cc=hdegoede@redhat.com \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox