From: Aymen Khalfa <a.khalfa.1012@gmail.com>
To: gregkh@linuxfoundation.org, hdegoede@redhat.com,
Larry.Finger@lwfinger.net
Cc: linux-staging@lists.linux.dev, Aymen Khalfa <a.khalfa.1012@gmail.com>
Subject: [PATCH] drivers: staging: rtl8723bs: Fixed coding style issues and msleep() issue.
Date: Wed, 16 Oct 2024 12:02:24 +0200 [thread overview]
Message-ID: <20241016100224.2449224-1-a.khalfa.1012@gmail.com> (raw)
-Fixed brace coding style issues.
-Fixed unaligned comments coding style issue.
-Replaced msleep(1) with usleep_range() as recommended in documentation.
Signed-off-by: Aymen Khalfa <a.khalfa.1012@gmail.com>
---
drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 31 ++++++++++----------
1 file changed, 16 insertions(+), 15 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
index dbfcbac3d855..d88e9f5bc1e8 100644
--- a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
+++ b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
@@ -56,9 +56,9 @@ int _ips_leave(struct adapter *padapter)
pwrpriv->ips_leave_cnts++;
result = rtw_ips_pwr_up(padapter);
- if (result == _SUCCESS) {
+ if (result == _SUCCESS)
pwrpriv->rf_pwrstate = rf_on;
- }
+
pwrpriv->bips_processing = false;
pwrpriv->bkeepfwalive = false;
@@ -429,15 +429,15 @@ s32 LPS_RF_ON_check(struct adapter *padapter, u32 delay_ms)
err = -1;
break;
}
- msleep(1);
+ usleep_range(1000, 2000);
}
return err;
}
/* */
-/* Description: */
-/* Enter the leisure power save mode. */
+/* Description: */
+/* Enter the leisure power save mode. */
/* */
void LPS_Enter(struct adapter *padapter, const char *msg)
{
@@ -476,8 +476,8 @@ void LPS_Enter(struct adapter *padapter, const char *msg)
}
/* */
-/* Description: */
-/* Leave the leisure power save mode. */
+/* Description: */
+/* Leave the leisure power save mode. */
/* */
void LPS_Leave(struct adapter *padapter, const char *msg)
{
@@ -556,9 +556,9 @@ void LeaveAllPowerSaveMode(struct adapter *Adapter)
LPS_Leave_check(Adapter);
} else {
- if (adapter_to_pwrctl(Adapter)->rf_pwrstate == rf_off) {
+ if (adapter_to_pwrctl(Adapter)->rf_pwrstate == rf_off)
ips_leave(Adapter);
- }
+
}
}
@@ -591,7 +591,7 @@ void LPS_Leave_check(struct adapter *padapter)
if (jiffies_to_msecs(jiffies - start_time) > 100)
break;
- msleep(1);
+ usleep_range(1000, 2000);
}
}
@@ -1011,15 +1011,16 @@ void rtw_free_pwrctrl_priv(struct adapter *adapter)
inline void rtw_set_ips_deny(struct adapter *padapter, u32 ms)
{
struct pwrctrl_priv *pwrpriv = adapter_to_pwrctl(padapter);
+
pwrpriv->ips_deny_time = jiffies + msecs_to_jiffies(ms);
}
/*
-* rtw_pwr_wakeup - Wake the NIC up from: 1)IPS. 2)USB autosuspend
-* @adapter: pointer to struct adapter structure
-* @ips_deffer_ms: the ms will prevent from falling into IPS after wakeup
-* Return _SUCCESS or _FAIL
-*/
+ * rtw_pwr_wakeup - Wake the NIC up from: 1)IPS. 2)USB autosuspend
+ * @adapter: pointer to struct adapter structure
+ * @ips_deffer_ms: the ms will prevent from falling into IPS after wakeup
+ * Return _SUCCESS or _FAIL
+ */
int _rtw_pwr_wakeup(struct adapter *padapter, u32 ips_deffer_ms, const char *caller)
{
--
2.34.1
next reply other threads:[~2024-10-16 10:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-16 10:02 Aymen Khalfa [this message]
2024-10-16 10:46 ` [PATCH] drivers: staging: rtl8723bs: Fixed coding style issues and msleep() issue Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241016100224.2449224-1-a.khalfa.1012@gmail.com \
--to=a.khalfa.1012@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox