Linux kernel staging patches
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Dave Penkler <dpenkler@gmail.com>
Cc: linux-staging@lists.linux.dev, Arnd Bergmann <arnd@arndb.de>
Subject: [PATCH 5/7] staging: gpib: add bus specific Kconfig dependencies
Date: Wed, 16 Oct 2024 11:15:19 +0000	[thread overview]
Message-ID: <20241016111521.1143191-6-arnd@kernel.org> (raw)
In-Reply-To: <20241016111521.1143191-1-arnd@kernel.org>

From: Arnd Bergmann <arnd@arndb.de>

A number of GPIB drivers fail to build when CONFIG_HAS_IOPORT is disabled,
which can be avoided with a CONFIG_ISA_BUS or CONFIG_PCMCIA dependency.

For completeness, mark all of the new device drivers with a dependency
on whichever bus they use, and hide the symbols for chip drivers that
are already selected by teh device drivers using them.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/staging/gpib/Kconfig | 17 +++++++++++++++--
 1 file changed, 15 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/gpib/Kconfig b/drivers/staging/gpib/Kconfig
index f5541624eaa7..8c550f669958 100644
--- a/drivers/staging/gpib/Kconfig
+++ b/drivers/staging/gpib/Kconfig
@@ -34,6 +34,7 @@ config GPIB_COMMON
 
 config GPIB_AGILENT_82350B
 	tristate "Agilent 8235xx PCI(e) adapters"
+	depends on PCI
 	select GPIB_COMMON
 	select GPIB_TMS9914
 	help
@@ -57,6 +58,8 @@ config GPIB_AGILENT_82357A
 
 config GPIB_CEC_PCI
 	tristate "CEC PCI board"
+	depends on PCI
+	depends on HAS_IOPORT
 	select GPIB_COMMON
 	select GPIB_NEC7210
 	help
@@ -68,6 +71,7 @@ config GPIB_CEC_PCI
 
 config GPIB_NI_PCI_ISA
 	tristate "NI PCI/ISA compatible boards"
+	depends on ISA_BUS
 	select GPIB_COMMON
 	select GPIB_NEC7210
 	help
@@ -89,6 +93,8 @@ config GPIB_NI_PCI_ISA
 
 config GPIB_CB7210
        tristate "Measurement Computing compatible boards"
+	depends on HAS_IOPORT
+	depends on ISA_BUS || PCI || PCMCIA
        select GPIB_COMMON
        help
        Enable support for Measurement Computing (Computer Boards):
@@ -118,6 +124,7 @@ config GPIB_NI_USB
 
 config GPIB_FLUKE
        tristate "Fluke"
+	depends on OF
        select GPIB_COMMON
        select GPIB_NEC7210
        help
@@ -140,6 +147,7 @@ config GPIB_FMH
 
 config GPIB_GPIO
        tristate "RPi GPIO bitbang"
+	depends on ARCH_BCM2835 || COMPIlE_TEST
        select GPIB_COMMON
        help
          GPIB bitbang driver Raspberry Pi GPIO adapters
@@ -149,6 +157,7 @@ config GPIB_GPIO
 
 config GPIB_HP82335
        tristate "HP82335/HP27209"
+	depends on ISA_BUS
        select GPIB_COMMON
        select GPIB_TMS9914
        help
@@ -172,6 +181,8 @@ config GPIB_HP82341
 
 config GPIB_INES
        tristate "INES"
+	depends on PCI || ISA_BUS || PCMCIA
+	depends on HAS_IOPORT
        select GPIB_COMMON
        select GPIB_NEC7210
        help
@@ -210,6 +221,8 @@ config GPIB_LPVO
 
 config GPIB_PC2
        tristate "PC2 PC2a"
+	depends on ISA_BUS
+	depends on HAS_IOPORT
        select GPIB_COMMON
        select GPIB_NEC7210
        help
@@ -227,7 +240,7 @@ config GPIB_PC2
 
 
 config GPIB_TMS9914
-       tristate "TMS 9914 GPIB Chip driver"
+       tristate
        select GPIB_COMMON
        help
          Enable support for TMS 9914 chip.
@@ -236,7 +249,7 @@ config GPIB_TMS9914
 	 called tms9914
 
 config GPIB_NEC7210
-       tristate "NEC 7210 GPIB Chip driver"
+       tristate
        select GPIB_COMMON
        help
          Enable support for NEC 7210 compatible chips.
-- 
2.39.5


  parent reply	other threads:[~2024-10-16 11:15 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-16 11:15 [PATCH 0/7] staging: gpib: randconfig build fixes Arnd Bergmann
2024-10-16 11:15 ` [PATCH 1/7] staging: gpib: add module descriptions Arnd Bergmann
2024-10-16 11:15 ` [PATCH 2/7] staging: gpib: avoid unused const variables Arnd Bergmann
2024-10-16 11:15 ` [PATCH 3/7] staging: gpib: pc2: avoid calling undefined dma_free() Arnd Bergmann
2024-10-16 11:15 ` [PATCH 4/7] staging: gpib: make port I/O code conditional Arnd Bergmann
2024-11-08 19:29   ` Nathan Chancellor
2024-10-16 11:15 ` Arnd Bergmann [this message]
2024-10-16 11:15 ` [PATCH 6/7] staging: gpib: use proper format string in request_module Arnd Bergmann
2024-10-16 11:15 ` [PATCH 7/7] staging: gpib: cb7210: select NEC7210 library Arnd Bergmann
2024-10-16 12:33 ` [PATCH 0/7] staging: gpib: randconfig build fixes Dave Penkler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241016111521.1143191-6-arnd@kernel.org \
    --to=arnd@kernel.org \
    --cc=arnd@arndb.de \
    --cc=dpenkler@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox