From: Omer Faruk BULUT <m.omerfarukbulut@gmail.com>
To: dpenkler@gmail.com
Cc: gregkh@linuxfoundation.org, arnd@arndb.de,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Omer Faruk BULUT <m.omerfarukbulut@gmail.com>
Subject: [PATCH] Staging: gpib/common/gpib_os.c - Remove unnecessary OOM message
Date: Tue, 22 Oct 2024 21:06:20 +0300 [thread overview]
Message-ID: <20241022180620.12429-1-m.omerfarukbulut@gmail.com> (raw)
It duplicate the MM subsystem generic OOM message. This patch fixes the following checkpatch warning.
WARNING: Possible unnecessary 'out of memory' message
Also, this patch itself might teach to module writers or readers that they have to give attention to MM subsystem
even they interest another one.
Signed-off-by: Omer Faruk BULUT <m.omerfarukbulut@gmail.com>
---
drivers/staging/gpib/common/gpib_os.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/gpib/common/gpib_os.c b/drivers/staging/gpib/common/gpib_os.c
index 6b12404efe7d..27654b2180a5 100644
--- a/drivers/staging/gpib/common/gpib_os.c
+++ b/drivers/staging/gpib/common/gpib_os.c
@@ -2093,10 +2093,9 @@ void gpib_register_driver(gpib_interface_t *interface, struct module *provider_m
struct gpib_interface_list_struct *entry;
entry = kmalloc(sizeof(*entry), GFP_KERNEL);
- if (!entry) {
- pr_err("gpib: failed register %s interface, out of memory\n", interface->name);
+ if (!entry)
return;
- }
+
entry->interface = interface;
entry->module = provider_module;
list_add(&entry->list, ®istered_drivers);
--
2.17.1
next reply other threads:[~2024-10-22 18:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-22 18:06 Omer Faruk BULUT [this message]
2024-11-03 23:45 ` [PATCH] Staging: gpib/common/gpib_os.c - Remove unnecessary OOM message Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241022180620.12429-1-m.omerfarukbulut@gmail.com \
--to=m.omerfarukbulut@gmail.com \
--cc=arnd@arndb.de \
--cc=dpenkler@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox