From: Dave Penkler <dpenkler@gmail.com>
To: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Cc: skhan@linuxfoundation.org, arnd@arndb.de,
dan.carpenter@linaro.org, Dave Penkler <dpenkler@gmail.com>
Subject: [PATCH v3 11/12] staging: gpib: Re-order the lookup tables
Date: Mon, 4 Nov 2024 18:50:12 +0100 [thread overview]
Message-ID: <20241104175014.12317-12-dpenkler@gmail.com> (raw)
In-Reply-To: <20241104175014.12317-1-dpenkler@gmail.com>
Re-order the tables so that the bcm27xx table is used first
as these devices are more popular and numerous than the older ones.
This is slightly more efficient for the later pi3 and subsequent models
but should not be noticable in practice for all users.
Signed-off-by: Dave Penkler <dpenkler@gmail.com>
---
drivers/staging/gpib/gpio/gpib_bitbang.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/gpib/gpio/gpib_bitbang.c b/drivers/staging/gpib/gpio/gpib_bitbang.c
index 78032af5061c..a2d562cbd65b 100644
--- a/drivers/staging/gpib/gpio/gpib_bitbang.c
+++ b/drivers/staging/gpib/gpio/gpib_bitbang.c
@@ -202,7 +202,7 @@ int gpios_vector[] = {
/* Lookup table for general GPIOs */
-static struct gpiod_lookup_table gpib_gpio_table_0 = {
+static struct gpiod_lookup_table gpib_gpio_table_1 = {
// for bcm2835/6
.dev_id = "", // device id of board device
.table = {
@@ -232,7 +232,7 @@ static struct gpiod_lookup_table gpib_gpio_table_0 = {
},
};
-static struct gpiod_lookup_table gpib_gpio_table_2 = {
+static struct gpiod_lookup_table gpib_gpio_table_0 = {
.dev_id = "", // device id of board device
.table = {
// for bcm27xx based pis (b b+ 2b 3b 3b+ 4 5)
@@ -264,7 +264,7 @@ static struct gpiod_lookup_table gpib_gpio_table_2 = {
static struct gpiod_lookup_table *lookup_tables[] = {
&gpib_gpio_table_0,
- &gpib_gpio_table_2,
+ &gpib_gpio_table_1,
0
};
--
2.46.2
next prev parent reply other threads:[~2024-11-04 17:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-04 17:50 [PATCH v3 00/12] staging: gpib: Patch set for gpib staging drivers Dave Penkler
2024-11-04 17:50 ` [PATCH v3 01/12] staging: gpib: Fix buffer overflow in ni_usb_init Dave Penkler
2024-11-04 17:50 ` [PATCH v3 02/12] staging: gpib: Replace custom debug with dev_dbg Dave Penkler
2024-11-04 17:50 ` [PATCH v3 03/12] staging: gpib: Update messaging and usb_device refs in ni_usb Dave Penkler
2024-11-04 17:50 ` [PATCH v3 04/12] staging: gpib: Update messaging and usb_device refs in agilent_usb Dave Penkler
2024-11-04 17:50 ` [PATCH v3 05/12] staging: gpib: Fix MODULES_DESCRIPTION Dave Penkler
2024-11-04 17:50 ` [PATCH v3 06/12] staging: gpib: Add comment for mutex define Dave Penkler
2024-11-04 17:50 ` [PATCH v3 07/12] staging: gpib: Use dev_xxx for messaging Dave Penkler
2024-11-04 17:50 ` [PATCH v3 08/12] staging: gpib: Fix Kconfig Dave Penkler
2024-11-04 17:50 ` [PATCH v3 09/12] staging: gpib: Remove unneeded lookup table Dave Penkler
2024-11-04 17:50 ` [PATCH v3 10/12] staging: gpib: Remove GPIO14 and GPIO15 lines in lookup tables Dave Penkler
2024-11-04 17:50 ` Dave Penkler [this message]
2024-11-04 17:50 ` [PATCH v3 12/12] staging: gpib: Correct check for max secondary address Dave Penkler
2024-11-05 6:33 ` [PATCH v3 00/12] staging: gpib: Patch set for gpib staging drivers Dan Carpenter
2024-11-05 8:22 ` Dave Penkler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241104175014.12317-12-dpenkler@gmail.com \
--to=dpenkler@gmail.com \
--cc=arnd@arndb.de \
--cc=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).