From: Greg KH <gregkh@linuxfoundation.org>
To: Kees Bakker <kees@ijzerbout.nl>
Cc: Dave Penkler <dpenkler@gmail.com>,
Linux Staging <linux-staging@lists.linux.dev>
Subject: Re: [PATCH V3] staging: gpib: avoid unintended sign extension
Date: Thu, 7 Nov 2024 09:28:37 +0100 [thread overview]
Message-ID: <2024110706-harmony-glowing-148b@gregkh> (raw)
In-Reply-To: <20241104193530.4AA8A18DD38@bout3.ijzerbout.nl>
On Thu, Oct 17, 2024 at 09:54:47PM +0200, Kees Bakker wrote:
> The code was basically like this (assuming size_t can be u64)
> var_u64 |= var_u8 << 24
> var_u8 is first promoted to i32 and then the shift is done. Next, it is
> promoted to u64 by first signextending to 64 bits. This is very unlikely
> what was intended. So now it is first forced to u32.
> var_u64 |= (u32)var_u8 << 24
>
> This was detected by Coverity, CID 1600792.
>
> Fixes: 4c41fe886a56 ("staging: gpib: Add Agilent/Keysight 82357x USB GPIB driver")
> Signed-off-by: Kees Bakker <kees@ijzerbout.nl>
> ---
> V1 -> V2: Changed commit message, added Fixes: tag and a reference to the Coverity CID
> V2 -> V3: add version in the subject (sorry Greg)
Doesn't apply cleanly anymore :(
Also, always cc: all of the relevent people that get_maintainer.pl says
to cc:. Can you rebase this against my staging-testing branch and
resend?
thanks,
greg k-h
prev parent reply other threads:[~2024-11-07 8:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-17 19:54 [PATCH V3] staging: gpib: avoid unintended sign extension Kees Bakker
2024-11-07 8:28 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024110706-harmony-glowing-148b@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=dpenkler@gmail.com \
--cc=kees@ijzerbout.nl \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).