From: Jonathan Cameron <jic23@kernel.org>
To: Zicheng Qu <quzicheng@huawei.com>
Cc: <lars@metafoo.de>, <Michael.Hennerich@analog.com>,
<gregkh@linuxfoundation.org>, <daniel.baluta@intel.com>,
<shubhrajyoti@ti.com>, <linux-iio@vger.kernel.org>,
<linux-staging@lists.linux.dev>, <linux-kernel@vger.kernel.org>,
<tanghui20@huawei.com>, <zhangqiao22@huawei.com>,
<judy.chenhui@huawei.com>
Subject: Re: [PATCH v2 0/2] Fix phase range check in AD9832 and AD9834 drivers
Date: Sat, 9 Nov 2024 14:39:45 +0000 [thread overview]
Message-ID: <20241109143945.2616c5d5@jic23-huawei> (raw)
In-Reply-To: <20241107011015.2472600-1-quzicheng@huawei.com>
On Thu, 7 Nov 2024 01:10:13 +0000
Zicheng Qu <quzicheng@huawei.com> wrote:
> Hi,
>
> The previous link is: https://lore.kernel.org/linux-iio/20241105140359.2465656-1-quzicheng@huawei.com/T/#u
>
> This patch (v2) addresses an issue in both the AD9832 and AD9834 drivers
> where the phase range check allows an invalid value of 4096. The
> condition has been corrected to ensure only valid 12-bit values (0-4095)
> are accepted.
>
> These changes ensure compliance with datasheet specifications and
> prevent potential issues with incorrect phase settings.
>
> Zicheng Qu (2):
> staging: iio: ad9834: Correct phase range check
> staging: iio: ad9832: Correct phase range check
>
> drivers/staging/iio/frequency/ad9832.c | 2 +-
> drivers/staging/iio/frequency/ad9834.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> Thank you for reviewing this patch.
>
For future reference, for IIO at least (and most of the kernel) don't
reply to previous version when posting a new version. That tends to
make it likely your patch set will be lost way up the pile of email
in a maintainers in box.
Many maintainers start at latest and work backwards until they run out
of time :)
Jonathan
> Best regards,
>
> Zicheng
prev parent reply other threads:[~2024-11-09 14:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-05 14:03 [PATCH 0/2] Correct Phase Range Check for AD9832 and AD9834 Drivers Zicheng Qu
2024-11-05 14:03 ` [PATCH 1/2] staging: iio: ad9834: Correct phase range check Zicheng Qu
2024-11-05 15:54 ` Dan Carpenter
2024-11-05 14:03 ` [PATCH 2/2] staging: iio: ad9832: " Zicheng Qu
2024-11-05 16:15 ` Dan Carpenter
2024-11-07 1:10 ` [PATCH v2 0/2] Fix phase range check in AD9832 and AD9834 drivers Zicheng Qu
2024-11-07 1:10 ` [PATCH v2 1/2] staging: iio: ad9834: Correct phase range check Zicheng Qu
2024-11-07 10:32 ` Dan Carpenter
2024-11-09 14:41 ` Jonathan Cameron
2024-11-07 1:10 ` [PATCH v2 2/2] staging: iio: ad9832: " Zicheng Qu
2024-11-09 14:39 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241109143945.2616c5d5@jic23-huawei \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=daniel.baluta@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=judy.chenhui@huawei.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=quzicheng@huawei.com \
--cc=shubhrajyoti@ti.com \
--cc=tanghui20@huawei.com \
--cc=zhangqiao22@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox