From: Dave Penkler <dpenkler@gmail.com>
To: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Cc: Dave Penkler <dpenkler@gmail.com>, Kees Bakker <kees@ijzerbout.nl>
Subject: [PATCH 4/4] staging: gpib: Fix faulty workaround for assignment in if
Date: Wed, 4 Dec 2024 15:57:13 +0100 [thread overview]
Message-ID: <20241204145713.11889-5-dpenkler@gmail.com> (raw)
In-Reply-To: <20241204145713.11889-1-dpenkler@gmail.com>
This was detected by Coverity.
Add the missing assignment in the else branch of the if
Reported-by: Kees Bakker <kees@ijzerbout.nl>
Fixes: fce79512a96a ("staging: gpib: Add LPVO DIY USB GPIB driver")
Signed-off-by: Dave Penkler <dpenkler@gmail.com>
---
drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c b/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c
index c30db3615f49..5114f6c519e5 100644
--- a/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c
+++ b/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c
@@ -899,7 +899,7 @@ static int usb_gpib_read(gpib_board_t *board,
} else {
/* we are in the closing <DLE><ETX> sequence */
-
+ c = nc;
if (c == ETX) {
c = one_char(board, &b);
if (c == ACK) {
--
2.47.1
prev parent reply other threads:[~2024-12-04 14:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-04 14:57 [PATCH 0/4] staging: gpib: Cleanup and fixes for lpvo driver Dave Penkler
2024-12-04 14:57 ` [PATCH 1/4] staging: gpib: Remove useless include Dave Penkler
2024-12-04 14:57 ` [PATCH 2/4] staging: gpib: Remove duplicate include Dave Penkler
2024-12-04 14:57 ` [PATCH 3/4] staging: gpib: Fix erroneous removal of blank before newline Dave Penkler
2024-12-04 15:29 ` Greg KH
2024-12-04 16:05 ` Dan Carpenter
2024-12-04 14:57 ` Dave Penkler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241204145713.11889-5-dpenkler@gmail.com \
--to=dpenkler@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kees@ijzerbout.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox