public inbox for linux-staging@lists.linux.dev
 help / color / mirror / Atom feed
From: Nihar Chaithanya <niharchaithanya@gmail.com>
To: dpenkler@gmail.com, gregkh@linuxfoundation.org
Cc: dan.carpenter@linaro.org, skhan@linuxfoundation.org,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
	Nihar Chaithanya <niharchaithanya@gmail.com>
Subject: [PATCH v5 10/15] staging: gpib: hp_82341: Handle gpib_register_driver() errors
Date: Sat, 28 Dec 2024 11:37:58 +0530	[thread overview]
Message-ID: <20241228060800.107653-11-niharchaithanya@gmail.com> (raw)
In-Reply-To: <20241228060800.107653-1-niharchaithanya@gmail.com>

The function gpib_register_driver() can fail, resulting in a
semi-registered module and does not return an error value if it
fails.

Return the error value if the first gpib_register_driver() fails
and if the second gpib_register_driver() fails unregister the first
gpib_register_driver() and return the error value.

Signed-off-by: Nihar Chaithanya <niharchaithanya@gmail.com>
---
 drivers/staging/gpib/hp_82341/hp_82341.c | 18 ++++++++++++++++--
 1 file changed, 16 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/gpib/hp_82341/hp_82341.c b/drivers/staging/gpib/hp_82341/hp_82341.c
index 8ad1c885a9fb..eaeed8fb77c3 100644
--- a/drivers/staging/gpib/hp_82341/hp_82341.c
+++ b/drivers/staging/gpib/hp_82341/hp_82341.c
@@ -807,8 +807,22 @@ MODULE_DEVICE_TABLE(pnp, hp_82341_pnp_table);
 
 static int __init hp_82341_init_module(void)
 {
-	gpib_register_driver(&hp_82341_unaccel_interface, THIS_MODULE);
-	gpib_register_driver(&hp_82341_interface, THIS_MODULE);
+	int ret;
+
+	ret = gpib_register_driver(&hp_82341_unaccel_interface, THIS_MODULE);
+	if (ret) {
+		pr_err("hp_82341: gpib_register_driver failed!\n");
+		return ret;
+	}
+
+	ret = gpib_register_driver(&hp_82341_interface, THIS_MODULE);
+	if (ret) {
+		pr_err("hp_82341: gpib_register_driver failed!\n");
+		gpib_unregister_driver(&hp_82341_unaccel_interface);
+		return ret;
+	}
+
+	pr_info("hp_82341: module init is complete\n");
 	return 0;
 }
 
-- 
2.34.1


  parent reply	other threads:[~2024-12-28  6:26 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-28  6:07 [PATCH v5 00/15] staging: gpib: Handle gpib_register_driver() errors Nihar Chaithanya
2024-12-28  6:07 ` [PATCH v5 01/15] staging: gpib: Modify gpib_register_driver() to return error if it fails Nihar Chaithanya
2024-12-29 10:30   ` Greg KH
2024-12-28  6:07 ` [PATCH v5 02/15] staging: gpib: agilent_82350b: Handle gpib_register_driver() errors Nihar Chaithanya
2024-12-29 10:29   ` Greg KH
2024-12-28  6:07 ` [PATCH v5 03/15] staging: gpib: agilent_82357a: " Nihar Chaithanya
2024-12-28  6:07 ` [PATCH v5 04/15] staging: gpib: cb7210: " Nihar Chaithanya
2024-12-28  6:07 ` [PATCH v5 05/15] staging: gpib: cec: " Nihar Chaithanya
2024-12-28  6:07 ` [PATCH v5 06/15] staging: gpib: fluke: " Nihar Chaithanya
2024-12-28  6:07 ` [PATCH v5 07/15] staging: gpib: fmh: " Nihar Chaithanya
2024-12-28  9:24   ` kernel test robot
2024-12-28  6:07 ` [PATCH v5 08/15] staging: gpib: gpio: Return error value from gpib_register_driver() Nihar Chaithanya
2024-12-28  6:07 ` [PATCH v5 09/15] staging: gpib: hp_82335: " Nihar Chaithanya
2024-12-28  6:07 ` Nihar Chaithanya [this message]
2024-12-28  6:07 ` [PATCH v5 11/15] staging: gpib: ines: Handle gpib_register_driver() errors Nihar Chaithanya
2024-12-29 10:28   ` Greg KH
2024-12-29 10:46     ` Nihar Chaithanya
2024-12-28  6:08 ` [PATCH v5 12/15] staging: gpib: lpvo_usb: Return error value from gpib_register_driver() Nihar Chaithanya
2024-12-28  6:08 ` [PATCH v5 13/15] staging: gpib: ni_usb: Handle gpib_register_driver() errors Nihar Chaithanya
2024-12-28  6:08 ` [PATCH v5 14/15] staging: gpib: pc2: " Nihar Chaithanya
2024-12-28  6:08 ` [PATCH v5 15/15] staging: gpib: tnt4882: " Nihar Chaithanya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241228060800.107653-11-niharchaithanya@gmail.com \
    --to=niharchaithanya@gmail.com \
    --cc=dan.carpenter@linaro.org \
    --cc=dpenkler@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox