From: Steven Davis <goldside000@outlook.com>
To: "johan@kernel.org" <johan@kernel.org>,
"elder@kernel.org" <elder@kernel.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Cc: "greybus-dev@lists.linaro.dev" <greybus-dev@lists.linaro.dev>,
"linux-staging@lists.linux.dev" <linux-staging@lists.linux.dev>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Steven Davis <goldside000@outlook.com>
Subject: [PATCH] staging: greybus: Log driver_register() failure
Date: Sat, 28 Dec 2024 16:57:44 +0000 [thread overview]
Message-ID: <20241228165720.16552-1-goldside000@outlook.com> (raw)
Currently, if driver_register() fails, it just returns retval
and fails silently. This behavior may make the error more difficult
to debug, as the error is not logged.
Adding pr_err() here will log the error descriptively, along with
driver name and the value that retval returned. That way, the error
is not silent and the user can see what happened.
Signed-off-by: Steven Davis <goldside000@outlook.com>
---
drivers/staging/greybus/gbphy.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/greybus/gbphy.c b/drivers/staging/greybus/gbphy.c
index 6adcad286..c6d1030b7 100644
--- a/drivers/staging/greybus/gbphy.c
+++ b/drivers/staging/greybus/gbphy.c
@@ -204,8 +204,10 @@ int gb_gbphy_register_driver(struct gbphy_driver *driver,
driver->driver.mod_name = mod_name;
retval = driver_register(&driver->driver);
- if (retval)
+ if (retval) {
+ pr_err("failed to register driver %s: %d\n", driver->name, retval);
return retval;
+ }
pr_info("registered new driver %s\n", driver->name);
return 0;
--
2.39.5
next reply other threads:[~2024-12-28 16:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-28 16:57 Steven Davis [this message]
2024-12-29 10:19 ` [PATCH] staging: greybus: Log driver_register() failure gregkh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241228165720.16552-1-goldside000@outlook.com \
--to=goldside000@outlook.com \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.dev \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).