From: Sandeep Salwan <salwansandeep5@gmail.com>
To: gregkh@linuxfoundation.org
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Sandeep Salwan <salwansandeep5@gmail.com>
Subject: [PATCH] staging: gpib: Convert // comments to kernel-style block comments
Date: Tue, 7 Jan 2025 19:27:57 -0500 [thread overview]
Message-ID: <20250108002757.43896-1-salwansandeep5@gmail.com> (raw)
This patch replaces several // single-line comments with multiline
block comments in agilent_82350b.c. According to kernel coding style
guidelines, we should prefer /* ... */ over // comments, especially
for multi-line or verbose text. This is purely code cleanup only.
Signed-off-by: Sandeep Salwan <salwansandeep5@gmail.com>
---
drivers/staging/gpib/agilent_82350b/agilent_82350b.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/gpib/agilent_82350b/agilent_82350b.c b/drivers/staging/gpib/agilent_82350b/agilent_82350b.c
index 53006d0cc79c..3cd01613d067 100644
--- a/drivers/staging/gpib/agilent_82350b/agilent_82350b.c
+++ b/drivers/staging/gpib/agilent_82350b/agilent_82350b.c
@@ -31,8 +31,10 @@ int agilent_82350b_accel_read(gpib_board_t *board, uint8_t *buffer, size_t lengt
int i, num_fifo_bytes;
//hardware doesn't support checking for end-of-string character when using fifo
if (tms_priv->eos_flags & REOS) {
- //pr_info("ag-rd: using tms9914 read for REOS %x EOS %x\n",tms_priv->eos_flags,
- // tms_priv->eos);
+ /*
+ * pr_info("ag-rd: using tms9914 read for REOS %x EOS %x\n",tms_priv->eos_flags,
+ * tms_priv->eos);
+ */
return tms9914_read(board, tms_priv, buffer, length, end, bytes_read);
}
--
2.47.1
next reply other threads:[~2025-01-08 0:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-08 0:27 Sandeep Salwan [this message]
2025-01-08 8:13 ` [PATCH] staging: gpib: Convert // comments to kernel-style block comments Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250108002757.43896-1-salwansandeep5@gmail.com \
--to=salwansandeep5@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox