Re: [PATCH v2] staging: gpib: Modernize gpib_interface_t initialization and make static

[kernel test robot <lkp@intel.com>]

Hi Dave,

kernel test robot noticed the following build errors:

[auto build test ERROR on staging/staging-testing]

url:    https://github.com/intel-lab-lkp/linux/commits/Dave-Penkler/staging-gpib-Modernize-gpib_interface_t-initialization-and-make-static/20250109-014247
base:   staging/staging-testing
patch link:    https://lore.kernel.org/r/20250108174121.23044-1-dpenkler%40gmail.com
patch subject: [PATCH v2] staging: gpib: Modernize gpib_interface_t initialization and make static
config: x86_64-randconfig-077-20250109 (https://download.01.org/0day-ci/archive/20250109/202501092356.ElX5uvEq-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250109/202501092356.ElX5uvEq-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202501092356.ElX5uvEq-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/staging/gpib/hp_82335/hp82335.c:175:25: error: static declaration of 'hp82335_interface' follows non-static declaration
     175 | static gpib_interface_t hp82335_interface = {
         |                         ^~~~~~~~~~~~~~~~~
   In file included from drivers/staging/gpib/hp_82335/hp82335.c:11:
   drivers/staging/gpib/hp_82335/hp82335.h:21:25: note: previous declaration of 'hp82335_interface' with type 'gpib_interface_t' {aka 'struct gpib_interface_struct'}
      21 | extern gpib_interface_t hp82335_interface;
         |                         ^~~~~~~~~~~~~~~~~


vim +/hp82335_interface +175 drivers/staging/gpib/hp_82335/hp82335.c

   174	
 > 175	static gpib_interface_t hp82335_interface = {
   176		.name = "hp82335",
   177		.attach = hp82335_attach,
   178		.detach = hp82335_detach,
   179		.read = hp82335_read,
   180		.write = hp82335_write,
   181		.command = hp82335_command,
   182		.request_system_control = hp82335_request_system_control,
   183		.take_control = hp82335_take_control,
   184		.go_to_standby = hp82335_go_to_standby,
   185		.interface_clear = hp82335_interface_clear,
   186		.remote_enable = hp82335_remote_enable,
   187		.enable_eos = hp82335_enable_eos,
   188		.disable_eos = hp82335_disable_eos,
   189		.parallel_poll = hp82335_parallel_poll,
   190		.parallel_poll_configure = hp82335_parallel_poll_configure,
   191		.parallel_poll_response = hp82335_parallel_poll_response,
   192		.local_parallel_poll_mode = NULL, // XXX
   193		.line_status = hp82335_line_status,
   194		.update_status = hp82335_update_status,
   195		.primary_address = hp82335_primary_address,
   196		.secondary_address = hp82335_secondary_address,
   197		.serial_poll_response = hp82335_serial_poll_response,
   198		.serial_poll_status = hp82335_serial_poll_status,
   199		.t1_delay = hp82335_t1_delay,
   200		.return_to_local = hp82335_return_to_local,
   201	};
   202	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki