From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Alex Elder <elder@ieee.org>,
Will Walsh <iron.will.walsh@gmail.com>,
Vaibhav Agarwal <vaibhav.sr@gmail.com>,
Mark Greer <mgreer@animalcreek.com>,
Johan Hovold <johan@kernel.org>, Alex Elder <elder@kernel.org>,
greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, outreachy@lists.linux.dev
Subject: Re: [PATCH] staging: greybus: remove unnecessary parentheses
Date: Thu, 9 Jan 2025 08:50:34 +0100 [thread overview]
Message-ID: <2025010932-rice-landed-2b96@gregkh> (raw)
In-Reply-To: <dcf6ec9f-39f2-4729-9250-14eb4d8d2adb@stanley.mountain>
On Thu, Jan 09, 2025 at 10:45:50AM +0300, Dan Carpenter wrote:
> On Wed, Jan 08, 2025 at 08:56:50PM -0600, Alex Elder wrote:
> > On 1/8/25 6:36 PM, Will Walsh wrote:
> > > Unnecessary parentheses in boolean comparisons make it harder to read.
> > >
> > > Removed the extra parentheses on line 305 for code readability.
> > >
> > > Signed-off-by: Will Walsh <iron.will.walsh@gmail.com>
> >
> > I'm not sure this makes a big difference in readability but I
> > personally avoid extra parentheses unless adding them makes a
> > compiler warning go away.
>
> It's not a compiler warning, it checkpatch.
And it is a checkpatch warning that I HATE and keep rejecting, here's
where I did so yesterday:
https://lore.kernel.org/r/2025010738-gong-rewind-2583@gregkh
Will, sorry, but I don't want to take this.
greg k-h
next prev parent reply other threads:[~2025-01-09 7:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-09 0:36 [PATCH] staging: greybus: remove unnecessary parentheses Will Walsh
2025-01-09 2:56 ` Alex Elder
2025-01-09 7:45 ` Dan Carpenter
2025-01-09 7:50 ` Greg Kroah-Hartman [this message]
2025-01-09 14:54 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025010932-rice-landed-2b96@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=dan.carpenter@linaro.org \
--cc=elder@ieee.org \
--cc=elder@kernel.org \
--cc=greybus-dev@lists.linaro.org \
--cc=iron.will.walsh@gmail.com \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mgreer@animalcreek.com \
--cc=outreachy@lists.linux.dev \
--cc=vaibhav.sr@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox