Re: [PATCH 00/17] staging: gpib: Console messaging cleanup

Greg KH
2025-02-20T09:19:15Z

On Thu, Feb 20, 2025 at 09:55:28AM +0100, Dave Penkler wrote:
> On Wed, Feb 19, 2025 at 04:48:39PM +0100, Greg KH wrote:
> > On Fri, Feb 14, 2025 at 12:46:51PM +0100, Dave Penkler wrote:
> > > The GPIB drivers printed a lot of spurious console messages. This
> > > was linked to the level of code maturity, often using console
> > > messages for debug.
> > >
> > > This patch set cleans up the console messaging in the spirit of Greg's
> > > recommendation: "When drivers are successful, they should be quiet"
> > >
> > > All pr_info's have been removed except for one which is in the module
> > > init of the common core driver indicating that the GPIB subsystem is
> > > initialized.
> > >
> > > All dev_info's have been removed or changed to dev_dbg except for the
> > > attach and probe messages in the agilent and ni usb drivers. This is
> > > to facilitate the creation of config and udev scripts to ensure that a
> > > particular usb device is systematically attached to the same gpib
> > > device file.
> > >
> > > All custom debug and tty logging has been removed or replaced with
> > > dev_dbg.
> > >
> > > Error messages where the user can figure out what went wrong with
> > > errno have also been removed, particularly timeouts and interrupts
> > > during reads and writes which can occur quite frequently uneccessarily
> > > cluttering up the console log.
> > >
> > > The patches are 1 per driver.
> >
> > All but 4 of these applied, can you rebase and resend the remaining
> > ones?
> >
> > thanks,
> >
> > greg k-h
> Sure, thanks.
> (Could only find 3 that were not applied, will send those)

Sorry, might have been three, my fault, it was a lot of me typing 'git
am --skip' :)

thanks,

greg k-h