From: Greg KH <gregkh@linuxfoundation.org>
To: Ian To <onlyian4981@gmail.com>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] staging: rtl8723bs: remove extra blank lines
Date: Sat, 15 Feb 2025 17:58:03 +0100 [thread overview]
Message-ID: <2025021535-riding-darkening-1c0d@gregkh> (raw)
In-Reply-To: <78f3702e2810424d12785f64334127a0f3cd82ef.1739351267.git.onlyian4981@gmail.com>
On Wed, Feb 12, 2025 at 01:22:56AM -0800, Ian To wrote:
> Repeated blank lines were present and removed. Reported by checkpatch.
>
> Signed-off-by: Ian To <onlyian4981@gmail.com>
> ---
> drivers/staging/rtl8723bs/core/rtw_security.c | 11 -----------
> 1 file changed, 11 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_security.c b/drivers/staging/rtl8723bs/core/rtw_security.c
> index e8f583206f92..18f640d48701 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_security.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_security.c
> @@ -123,7 +123,6 @@ void rtw_wep_decrypt(struct adapter *padapter, u8 *precvframe)
>
> /* calculate icv and compare the icv */
> *((u32 *)crc) = ~crc32_le(~0, payload, length - 4);
> -
> }
This was not a "repeated blank line".
> }
>
> @@ -219,10 +218,8 @@ void rtw_secgetmic(struct mic_data *pmicdata, u8 *dst)
> secmicclear(pmicdata);
> }
>
> -
> void rtw_seccalctkipmic(u8 *key, u8 *header, u8 *data, u32 data_len, u8 *mic_code, u8 pri)
> {
> -
> struct mic_data micdata;
> u8 priority[4] = {0x0, 0x0, 0x0, 0x0};
>
Neither was that :(
I've stopped reviewing here.
thanks,
greg k-h
prev parent reply other threads:[~2025-02-15 16:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-12 9:22 [PATCH v2 0/3] Adhere to coding style Ian To
2025-02-12 9:22 ` [PATCH v2 1/3] staging: rtl8723bs: format comments Ian To
2025-02-15 16:56 ` Greg KH
2025-02-12 9:22 ` [PATCH v2 2/3] stagin: rtl8723bs: fix spacing Ian To
2025-02-15 16:57 ` Greg KH
2025-02-12 9:22 ` [PATCH v2 3/3] staging: rtl8723bs: remove extra blank lines Ian To
2025-02-15 16:58 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025021535-riding-darkening-1c0d@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=onlyian4981@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox