From: Ricardo Ribalda <ribalda@chromium.org>
To: Mauro Carvalho Chehab <mchehab@kernel.org>,
Mike Isely <isely@pobox.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Hans de Goede <hdegoede@redhat.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Andy Shevchenko <andy@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Hans Verkuil <hverkuil@xs4all.nl>
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-staging@lists.linux.dev,
Ricardo Ribalda <ribalda@chromium.org>
Subject: [PATCH v3 09/12] media: cx231xx: Remove vidioc_s_ctrl callback
Date: Sun, 23 Feb 2025 18:58:12 +0000 [thread overview]
Message-ID: <20250223-queryctrl-v3-9-4292911cab6b@chromium.org> (raw)
In-Reply-To: <20250223-queryctrl-v3-0-4292911cab6b@chromium.org>
The driver has been converted to the control framework in the past:
commit 88b6ffedd901 ("[media] cx231xx-417: convert to the control
framework").
This function is never called, the core will only use the control
framework instead.
Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
---
drivers/media/usb/cx231xx/cx231xx-417.c | 15 ---------------
1 file changed, 15 deletions(-)
diff --git a/drivers/media/usb/cx231xx/cx231xx-417.c b/drivers/media/usb/cx231xx/cx231xx-417.c
index a4a9781328c5..5a4b0f96cca2 100644
--- a/drivers/media/usb/cx231xx/cx231xx-417.c
+++ b/drivers/media/usb/cx231xx/cx231xx-417.c
@@ -1538,20 +1538,6 @@ static int vidioc_s_std(struct file *file, void *priv, v4l2_std_id id)
return 0;
}
-static int vidioc_s_ctrl(struct file *file, void *priv,
- struct v4l2_control *ctl)
-{
- struct cx231xx *dev = video_drvdata(file);
- struct v4l2_subdev *sd;
-
- dprintk(3, "enter vidioc_s_ctrl()\n");
- /* Update the A/V core */
- v4l2_device_for_each_subdev(sd, &dev->v4l2_dev)
- v4l2_s_ctrl(NULL, sd->ctrl_handler, ctl);
- dprintk(3, "exit vidioc_s_ctrl()\n");
- return 0;
-}
-
static int vidioc_enum_fmt_vid_cap(struct file *file, void *priv,
struct v4l2_fmtdesc *f)
{
@@ -1627,7 +1613,6 @@ static const struct v4l2_ioctl_ops mpeg_ioctl_ops = {
.vidioc_enum_input = cx231xx_enum_input,
.vidioc_g_input = cx231xx_g_input,
.vidioc_s_input = cx231xx_s_input,
- .vidioc_s_ctrl = vidioc_s_ctrl,
.vidioc_g_pixelaspect = vidioc_g_pixelaspect,
.vidioc_g_selection = vidioc_g_selection,
.vidioc_querycap = cx231xx_querycap,
--
2.48.1.601.g30ceb7b040-goog
next prev parent reply other threads:[~2025-02-23 18:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-23 18:58 [PATCH v3 00/12] media: Remove vidioc_g/s_ctrl and vidioc_queryctrl callbacks Ricardo Ribalda
2025-02-23 18:58 ` [PATCH v3 01/12] media: ioctl: Simulate v4l2_queryctrl with v4l2_query_ext_ctrl Ricardo Ribalda
2025-02-23 18:58 ` [PATCH v3 02/12] media: pvrusb2: Convert queryctrl to query_ext_ctrl Ricardo Ribalda
2025-02-23 18:58 ` [PATCH v3 03/12] media: pvrusb2: Remove g/s_ctrl callbacks Ricardo Ribalda
2025-02-23 18:58 ` [PATCH v3 04/12] media: uvcvideo: Remove vidioc_queryctrl Ricardo Ribalda
2025-02-23 18:58 ` [PATCH v3 05/12] media: atomisp: Replace queryctrl with query_ext_ctrl Ricardo Ribalda
2025-02-23 18:58 ` [PATCH v3 06/12] media: atomisp: Remove vidioc_g/s callback Ricardo Ribalda
2025-02-23 18:58 ` [PATCH v3 07/12] media: v4l2: Remove vidioc_queryctrl callback Ricardo Ribalda
2025-02-23 18:58 ` [PATCH v3 08/12] media: v4l2: Remove vidioc_g_ctrl callback Ricardo Ribalda
2025-02-23 18:58 ` Ricardo Ribalda [this message]
2025-02-25 8:19 ` [PATCH v3 09/12] media: cx231xx: Remove vidioc_s_ctrl callback Hans Verkuil
2025-02-23 18:58 ` [PATCH v3 10/12] media: v4l2: " Ricardo Ribalda
2025-02-23 18:58 ` [PATCH v3 11/12] media: v4l2-core: Introduce v4l2_query_ext_ctrl_to_v4l2_queryctrl Ricardo Ribalda
2025-02-23 18:58 ` [PATCH v3 12/12] media: radio-wl1273: Rename wl1273_fm_vidioc_s_ctrl Ricardo Ribalda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250223-queryctrl-v3-9-4292911cab6b@chromium.org \
--to=ribalda@chromium.org \
--cc=andy@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=hverkuil@xs4all.nl \
--cc=isely@pobox.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox