From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A3C420FAB9; Mon, 3 Mar 2025 12:56:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741006604; cv=none; b=e8UsQpMHenxwHhulhSLjDr1EN1DwsCMw44dsa3d8EkAAQujedQXMrCFfs+T36rdGb6OIRz7XXTMP7acQR1iBNZfYbiUhgAj8Nb8DNiXRDNlZz2B6Je5yoABWwsLcIs6+GEFk8zTTwOKXsoNNsQl1AEfRJzqNmBDsZG7KCE/zF8Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741006604; c=relaxed/simple; bh=zBpdfr05Ho1fS7EiczKuumrPUmBYTKjWBPWuy/77H+I=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=uKdIKRtI7+O9FuTh665EUdMp4GvXKO8MuywCGz8/N77YKsL1S6ceIPhqogYr9m2FytXJN6zD31MTl+3Q95fU5QazvuQDTu29YM9fSwxQusZDJVbybChs6ipcerczn1KSDfqrL7YswnP/O1kZsKD3vUOofC+ufxBtgO8JtyB8sT8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=IM1ITgS5; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="IM1ITgS5" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2E696C4CED6; Mon, 3 Mar 2025 12:56:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1741006603; bh=zBpdfr05Ho1fS7EiczKuumrPUmBYTKjWBPWuy/77H+I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IM1ITgS5ZODPLmGIgbVJnVplYiRlss2mC9jCTrj9YNAC40yHKVNYXbMufpYsvaKRO h2XILlNtqXI3nOCPtVJXjSLCNp71WeQ/8Kmg2mE4R2JIhZONky7QfScKcveFM2MKjk EIzsefVdOb/2W3GJYK+IydJawPbeV1xxc7fll4M8= Date: Mon, 3 Mar 2025 13:56:40 +0100 From: Greg KH To: Saalim Quadri Cc: jic23@kernel.org, lars@metafoo.de, Michael.Hennerich@analog.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev Subject: Re: [PATCH] staging: iio: ad5933: Fix CamelCase naming Message-ID: <2025030301-niece-evacuate-0f05@gregkh> References: <20250303125246.342704-1-danascape@gmail.com> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250303125246.342704-1-danascape@gmail.com> On Mon, Mar 03, 2025 at 06:22:46PM +0530, Saalim Quadri wrote: > Reported by checkpatch: > > CHECK: Avoid CamelCase > > Signed-off-by: Saalim Quadri > --- > drivers/staging/iio/impedance-analyzer/ad5933.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/staging/iio/impedance-analyzer/ad5933.c b/drivers/staging/iio/impedance-analyzer/ad5933.c > index d5544fc2fe98..a1a5eee4f736 100644 > --- a/drivers/staging/iio/impedance-analyzer/ad5933.c > +++ b/drivers/staging/iio/impedance-analyzer/ad5933.c > @@ -43,10 +43,10 @@ > #define AD5933_CTRL_POWER_DOWN (0xA << 4) > #define AD5933_CTRL_STANDBY (0xB << 4) > > -#define AD5933_CTRL_RANGE_2000mVpp (0x0 << 1) > -#define AD5933_CTRL_RANGE_200mVpp (0x1 << 1) > -#define AD5933_CTRL_RANGE_400mVpp (0x2 << 1) > -#define AD5933_CTRL_RANGE_1000mVpp (0x3 << 1) > +#define AD5933_CTRL_RANGE_2000MVPP (0x0 << 1) > +#define AD5933_CTRL_RANGE_200MVPP (0x1 << 1) > +#define AD5933_CTRL_RANGE_400MVPP (0x2 << 1) > +#define AD5933_CTRL_RANGE_1000MVPP (0x3 << 1) No, these are units of measurement, the "m" is correct here, right? If you change that to "M" it logically means something a lot different :( Please always treat checkpatch.pl as a hint, not as a rule. thanks, greg k-h