From: Jonathan Cameron <jic23@kernel.org>
To: Saalim Quadri <danascape@gmail.com>
Cc: lars@metafoo.de, Michael.Hennerich@analog.com,
gregkh@linuxfoundation.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev
Subject: Re: [PATCH v2] staging: iio: adis16203: Remove unneeded spi_set_drvdata()
Date: Sat, 8 Mar 2025 14:48:01 +0000 [thread overview]
Message-ID: <20250308144801.08083814@jic23-huawei> (raw)
In-Reply-To: <20250305234949.1548646-1-danascape@gmail.com>
On Thu, 6 Mar 2025 05:19:49 +0530
Saalim Quadri <danascape@gmail.com> wrote:
> By making use of devm_iio_device_register(), we no longer have a driver
> remove callback.
> Since this was the last user of spi_get_drvdata(),
> we can drop the call to spi_set_drvdata().
>
> Signed-off-by: Saalim Quadri <danascape@gmail.com>
As per other discussion. Dropping this one as
better to merge support into the adis16201 driver.
> ---
> drivers/staging/iio/accel/adis16203.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/staging/iio/accel/adis16203.c b/drivers/staging/iio/accel/adis16203.c
> index c1c73308800c..3faf3c61046a 100644
> --- a/drivers/staging/iio/accel/adis16203.c
> +++ b/drivers/staging/iio/accel/adis16203.c
> @@ -267,8 +267,6 @@ static int adis16203_probe(struct spi_device *spi)
> if (!indio_dev)
> return -ENOMEM;
> st = iio_priv(indio_dev);
> - /* this is only used for removal purposes */
> - spi_set_drvdata(spi, indio_dev);
>
> indio_dev->name = spi->dev.driver->name;
> indio_dev->channels = adis16203_channels;
prev parent reply other threads:[~2025-03-08 14:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-05 23:49 [PATCH v2] staging: iio: adis16203: Remove unneeded spi_set_drvdata() Saalim Quadri
2025-03-06 0:06 ` Saalim Quadri
2025-03-08 14:48 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250308144801.08083814@jic23-huawei \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=danascape@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox