From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: Aditya Garg <gargaditya08@live.com>
Cc: "bhelgaas@google.com" <bhelgaas@google.com>,
"joro@8bytes.org" <joro@8bytes.org>,
"will@kernel.org" <will@kernel.org>,
"robin.murphy@arm.com" <robin.murphy@arm.com>,
"andriy.shevchenko@linux.intel.com"
<andriy.shevchenko@linux.intel.com>,
"linux-staging@lists.linux.dev" <linux-staging@lists.linux.dev>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"iommu@lists.linux.dev" <iommu@lists.linux.dev>,
Aun-Ali Zaidi <admin@kodeit.net>, "paul@mrarm.io" <paul@mrarm.io>,
Orlando Chamberlain <orlandoch.dev@gmail.com>
Subject: Re: [PATCH RFC] staging: Add driver to communicate with the T2 Security Chip
Date: Sun, 9 Mar 2025 10:55:12 +0100 [thread overview]
Message-ID: <2025030901-deceiver-jolliness-53f5@gregkh> (raw)
In-Reply-To: <PN3PR01MB95970E60B250F91CA8E12720B8D72@PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM>
On Sun, Mar 09, 2025 at 09:52:43AM +0000, Aditya Garg wrote:
>
>
> > On 9 Mar 2025, at 3:21 PM, gregkh@linuxfoundation.org wrote:
> >
> > On Sun, Mar 09, 2025 at 09:41:29AM +0000, Aditya Garg wrote:
> >>
> >>
> >>>> On 9 Mar 2025, at 3:09 PM, gregkh@linuxfoundation.org wrote:
> >>>
> >>> On Sun, Mar 09, 2025 at 09:28:01AM +0000, Aditya Garg wrote:
> >>>>
> >>>>
> >>>>>> On 9 Mar 2025, at 2:46 PM, gregkh@linuxfoundation.org wrote:
> >>>>>
> >>>>> On Sun, Mar 09, 2025 at 09:03:29AM +0000, Aditya Garg wrote:
> >>>>>>
> >>>>>>
> >>>>>>>> On 9 Mar 2025, at 2:24 PM, gregkh@linuxfoundation.org wrote:
> >>>>>>>
> >>>>>>> On Sun, Mar 09, 2025 at 08:40:31AM +0000, Aditya Garg wrote:
> >>>>>>>> From: Paul Pawlowski <paul@mrarm.io>
> >>>>>>>>
> >>>>>>>> This patch adds a driver named apple-bce, to add support for the T2
> >>>>>>>> Security Chip found on certain Macs.
> >>>>>>>>
> >>>>>>>> The driver has 3 main components:
> >>>>>>>>
> >>>>>>>> BCE (Buffer Copy Engine) - this is what the files in the root directory
> >>>>>>>> are for. This estabilishes a basic communication channel with the T2.
> >>>>>>>> VHCI and Audio both require this component.
> >>>>>>>
> >>>>>>> So this is a new "bus" type? Or a platform resource? Or something
> >>>>>>> else?
> >>>>>>
> >>>>>> It's a PCI device
> >>>>>
> >>>>> Great, but then is the resources split up into smaller drivers that then
> >>>>> bind to it? How does the other devices talk to this?
> >>>>
> >>>> We technically can split up these 3 into separate drivers and put then into their own trees.
> >>>
> >>> That's fine, but you say that the bce code is used by the other drivers,
> >>> right? So there is some sort of "tie" between these, and that needs to
> >>> be properly conveyed in the device tree in sysfs as that will be
> >>> required for proper resource management.
> >>
> >> Yes there needs to be a tie, basically first establish a communication with the t2 using bce and then the other 2 come into the picture. I did get a basic idea from what the maintainers want, and this will be some work to do. Thanks for your inputs!
> >
> > If there is "communication" then that's a bus in the driver model
> > scheme, so just use that, right?
>
> So basically RE the whole driver to see what exactly should be use?
I'm sorry, I can not parse this.
next prev parent reply other threads:[~2025-03-09 9:56 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-09 8:40 [PATCH RFC] staging: Add driver to communicate with the T2 Security Chip Aditya Garg
2025-03-09 8:44 ` Aditya Garg
2025-03-09 8:49 ` gregkh
2025-03-09 9:00 ` Aditya Garg
2025-03-09 9:13 ` gregkh
2025-03-09 8:52 ` gregkh
2025-03-09 8:54 ` gregkh
2025-03-09 9:05 ` Aditya Garg
2025-03-09 9:15 ` gregkh
2025-03-09 9:03 ` Aditya Garg
2025-03-09 9:14 ` gregkh
2025-03-09 9:28 ` Aditya Garg
2025-03-09 9:37 ` gregkh
2025-03-09 9:41 ` Aditya Garg
2025-03-09 9:48 ` gregkh
2025-03-09 9:52 ` Aditya Garg
2025-03-09 9:55 ` gregkh [this message]
2025-03-09 10:12 ` Aditya Garg
2025-03-09 10:22 ` gregkh
2025-03-09 10:33 ` Aditya Garg
2025-03-10 8:14 ` Dan Carpenter
2025-03-10 8:45 ` Aditya Garg
2025-03-10 13:49 ` Robin Murphy
2025-03-10 13:54 ` andriy.shevchenko
2025-03-10 13:59 ` Aditya Garg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025030901-deceiver-jolliness-53f5@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=admin@kodeit.net \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=gargaditya08@live.com \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=orlandoch.dev@gmail.com \
--cc=paul@mrarm.io \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox