From: Greg KH <gregkh@linuxfoundation.org>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc: dpenkler@gmail.com, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH -next 2/2] staging: gpib: Remove unnecessary print function dev_err()
Date: Thu, 20 Mar 2025 07:01:19 -0700 [thread overview]
Message-ID: <2025032037-antibody-emptier-9986@gregkh> (raw)
In-Reply-To: <20250226060735.7484-2-jiapeng.chong@linux.alibaba.com>
On Wed, Feb 26, 2025 at 02:07:35PM +0800, Jiapeng Chong wrote:
> The print function dev_err() is redundant because platform_get_irq()
> already prints an error.
>
> ./drivers/staging/gpib/fmh_gpib/fmh_gpib.c:1426:2-9: line 1426 is redundant because platform_get_irq() already prints an error.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=19059
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> drivers/staging/gpib/fmh_gpib/fmh_gpib.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
You have 2 different patches here, yet the identical subject line. I
just caught this after I added it to my staging-testing branch, so I'll
go drop it from there now and wait for a v2 series.
thanks,
greg k-h
prev parent reply other threads:[~2025-03-20 14:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-26 6:07 [PATCH -next 1/2] staging: gpib: Remove unnecessary print function dev_err() Jiapeng Chong
2025-02-26 6:07 ` [PATCH -next 2/2] " Jiapeng Chong
2025-03-20 14:01 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025032037-antibody-emptier-9986@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=abaci@linux.alibaba.com \
--cc=dpenkler@gmail.com \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox