linux-staging.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: gshahrouzi@gmail.com
Cc: linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
	slongerbeam@gmail.com, p.zabel@pengutronix.de,
	mchehab@kernel.org, skhan@linuxfoundation.org,
	kernelmentees@lists.linuxfoundation.org
Subject: Re: [PATCH] staging: media: Remove unnecessary braces for single
Date: Wed, 2 Apr 2025 07:15:00 +0100	[thread overview]
Message-ID: <2025040246-smith-unfixed-bb4c@gregkh> (raw)
In-Reply-To: <67ec86f5.d40a0220.2fb67c.97f0@mx.google.com>

On Tue, Apr 01, 2025 at 05:38:13PM -0700, gshahrouzi@gmail.com wrote:
> >>From 2414aa327e8a2b2f8b7cb5673c20bcdea3c5763e Mon Sep 17 00:00:00 2001
> From: Gabriel Shahrouzi <gshahrouzi@gmail.com>
> Date: Tue, 1 Apr 2025 20:22:22 -0400
> Subject: [PATCH] staging: media: Remove unnecessary braces for single
>  statement block
> 
> Remove unnecessary braces in single statement block to comply with kernel
> coding style.
> ---
>  drivers/staging/media/imx/imx-media-of.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/media/imx/imx-media-of.c b/drivers/staging/media/imx/imx-media-of.c
> index bb28daa4d713..7413551052ae 100644
> --- a/drivers/staging/media/imx/imx-media-of.c
> +++ b/drivers/staging/media/imx/imx-media-of.c
> @@ -57,9 +57,8 @@ int imx_media_add_of_subdevs(struct imx_media_dev *imxmd,
>  		of_node_put(csi_np);
>  		if (ret) {
>  			/* unavailable or already added is not an error */
> -			if (ret == -ENODEV || ret == -EEXIST) {
> +			if (ret == -ENODEV || ret == -EEXIST)
>  				continue;
> -			}
>  
>  			/* other error, can't continue */
>  			return ret;
> -- 
> 2.43.0
> 


Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch does not have a Signed-off-by: line.  Please read the
  kernel file, Documentation/process/submitting-patches.rst and resend
  it after adding that line.  Note, the line needs to be in the body of
  the email, before the patch, not at the bottom of the patch or in the
  email signature.


If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot

      reply	other threads:[~2025-04-02  6:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-02  0:38 [PATCH] staging: media: Remove unnecessary braces for single gshahrouzi
2025-04-02  6:15 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2025040246-smith-unfixed-bb4c@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=gshahrouzi@gmail.com \
    --cc=kernelmentees@lists.linuxfoundation.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=mchehab@kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=skhan@linuxfoundation.org \
    --cc=slongerbeam@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).