From: Greg KH <gregkh@linuxfoundation.org>
To: nancyenos <nicymimz@gmail.com>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
outreachy@lists.linux.dev
Subject: Re: [PATCH] staging: octeon: Fix unused macro Argument 'x'
Date: Thu, 3 Apr 2025 15:09:36 +0100 [thread overview]
Message-ID: <2025040315-squid-gloating-e0df@gregkh> (raw)
In-Reply-To: <20250325100952.2956-1-nicymimz@gmail.com>
On Tue, Mar 25, 2025 at 03:09:52AM -0700, nancyenos wrote:
> warning found by checkpath.pl
>
> Signed-off-by: nancyenos <nicymimz@gmail.com>
> ---
> drivers/staging/octeon/octeon-stubs.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/octeon/octeon-stubs.h b/drivers/staging/octeon/octeon-stubs.h
> index 44cced319c11..0155f3c41657 100644
> --- a/drivers/staging/octeon/octeon-stubs.h
> +++ b/drivers/staging/octeon/octeon-stubs.h
> @@ -8,8 +8,8 @@
> #define OCTEON_IRQ_WORKQ0 0
> #define OCTEON_IRQ_RML 0
> #define OCTEON_IRQ_TIMER1 0
> -#define OCTEON_IS_MODEL(x) 0
> -#define octeon_has_feature(x) 0
> +#define OCTEON_IS_MODEL(x) ((void)(x), 0)
> +#define octeon_has_feature(x) ((void)(x), 0)
> #define octeon_get_clock_rate() 0
>
> #define CVMX_SYNCIOBDMA do { } while (0)
> --
> 2.25.1
>
>
You sent this twice?
And always test-build your patches before submitting them. This
obviously will not build :(
thanks,
greg k-h
next prev parent reply other threads:[~2025-04-03 14:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-25 10:09 [PATCH] staging: octeon: Fix unused macro Argument 'x' nancyenos
2025-03-25 11:44 ` Julia Lawall
2025-03-29 2:47 ` kernel test robot
2025-04-03 14:09 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-03-22 0:32 nancyenos
2025-03-22 6:59 ` kernel test robot
2025-03-23 2:20 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025040315-squid-gloating-e0df@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=nicymimz@gmail.com \
--cc=outreachy@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).