From: Greg KH <gregkh@linuxfoundation.org>
To: Abraham Samuel Adekunle <abrahamadekunle50@gmail.com>
Cc: outreachy@lists.linux.dev, julia.lawall@inria.fr,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
dan.carpenter@linaro.org
Subject: Re: [v4] staging: rtl8723bs: modify struct field to use standard bool type
Date: Fri, 4 Apr 2025 09:00:14 +0100 [thread overview]
Message-ID: <2025040401-disobey-flop-d7be@gregkh> (raw)
In-Reply-To: <Z++PnxFQFe+IexUi@HP-650>
On Fri, Apr 04, 2025 at 08:51:59AM +0100, Abraham Samuel Adekunle wrote:
> The struct sta_info field ieee8021x_blocked uses the uint values
> 0 and 1 to represent false and true values respectively.
Nit, you don't say "PATCH" in the subject line, why not?
>
> Convert cases to use the bool type instead to ensure consistency
> with other parts of the containing code where true or false have
> been used.
>
> This change causes the struct field to change size from a 32bit to
> an 8bit. However, the change is safe to make because the sta_info
> struct is not read from the hardware.
>
> reported by Coccinelle:
Shouldn't something come after a ":"?
thanks,
greg k-h
next prev parent reply other threads:[~2025-04-04 8:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-04 7:51 [v4] staging: rtl8723bs: modify struct field to use standard bool type Abraham Samuel Adekunle
2025-04-04 8:00 ` Greg KH [this message]
2025-04-04 8:19 ` Samuel Abraham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025040401-disobey-flop-d7be@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=abrahamadekunle50@gmail.com \
--cc=dan.carpenter@linaro.org \
--cc=julia.lawall@inria.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox