From: Greg KH <gregkh@linuxfoundation.org>
To: sunliming@linux.dev
Cc: dpenkler@gmail.com, dan.carpenter@linaro.org, arnd@arndb.de,
niharchaithanya@gmail.com, everestkc@everestkc.com.np,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
sunliming <sunliming@kylinos.cn>,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH RESEND] staging: gpib: warning: variable 'nec_priv' set but not used warning
Date: Fri, 4 Apr 2025 07:25:44 +0100 [thread overview]
Message-ID: <2025040427-escargot-nanometer-6cd4@gregkh> (raw)
In-Reply-To: <20250404061135.330056-1-sunliming@linux.dev>
On Fri, Apr 04, 2025 at 02:11:35PM +0800, sunliming@linux.dev wrote:
> From: sunliming <sunliming@kylinos.cn>
>
> Fix below kernel warning:
> drivers/staging/gpib/eastwood/fluke_gpib.c:196:23: warning: variable 'nec_priv' set but not
> used [-Wunused-but-set-variable]
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202503200532.B4rXNs0N-lkp@intel.com/
> Signed-off-by: sunliming <sunliming@kylinos.cn>
> ---
> drivers/staging/gpib/eastwood/fluke_gpib.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/staging/gpib/eastwood/fluke_gpib.c b/drivers/staging/gpib/eastwood/fluke_gpib.c
> index 0304c5de4ccd..6854a745ccff 100644
> --- a/drivers/staging/gpib/eastwood/fluke_gpib.c
> +++ b/drivers/staging/gpib/eastwood/fluke_gpib.c
> @@ -194,10 +194,8 @@ static int fluke_line_status(const gpib_board_t *board)
> int status = ValidALL;
> int bsr_bits;
> struct fluke_priv *e_priv;
> - struct nec7210_priv *nec_priv;
>
> e_priv = board->private_data;
> - nec_priv = &e_priv->nec7210_priv;
>
> bsr_bits = fluke_paged_read_byte(e_priv, BUS_STATUS, BUS_STATUS_PAGE);
>
> --
> 2.25.1
>
>
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that has triggered this response. He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created. Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.
You are receiving this message because of the following common error(s)
as indicated below:
- This looks like a new version of a previously submitted patch, but you
did not list below the --- line any changes from the previous version.
Please read the section entitled "The canonical patch format" in the
kernel file, Documentation/process/submitting-patches.rst for what
needs to be done here to properly describe this.
If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.
thanks,
greg k-h's patch email bot
prev parent reply other threads:[~2025-04-04 6:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-04 6:11 [PATCH RESEND] staging: gpib: warning: variable 'nec_priv' set but not used warning sunliming
2025-04-04 6:25 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025040427-escargot-nanometer-6cd4@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=dan.carpenter@linaro.org \
--cc=dpenkler@gmail.com \
--cc=everestkc@everestkc.com.np \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=lkp@intel.com \
--cc=niharchaithanya@gmail.com \
--cc=sunliming@kylinos.cn \
--cc=sunliming@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox