Re: [v3 0/1] Unnecessary code cleanup patches

Julia Lawall
2025-04-05T08:49:46Z

On Sat, 5 Apr 2025, Greg KH wrote:

> On Fri, Apr 04, 2025 at 01:02:19AM +0100, Abraham Samuel Adekunle wrote:
> > The patchset modifies unnecessary duplicate NULL test on a
> > value in an expression, when the value has been NULL tested in a
> > previous expression.
>
> Nit, the subject line does nto have "staging:" in it, so I don't know
> where this goes.
>
> Also, it really reads as "this is an unnecessary patch" :)

Technically, in English, if you have a noun that is being used as an
adjective and that noun is itself modified in some way, you should use a
hyphen:

Unnecessary-code cleanup patches

But something like

Remove unnecessary code

would have had no ambiguity at all. Also everything you are doing is a
patch, so "patches" in the subject line doesn't seem very necessary.

julia

>
> And finally, for a single patch, there's usually not a need for a 0/X
> email to describe it, everything should be in just the single patch
> itself.
>
> thanks,
>
> greg k-h
>
>