From: Michael Rubin <matchstick@neverthere.org>
To: gregkh@linuxfoundation.org, dpenkler@gmail.com,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Cc: Michael Rubin <matchstick@neverthere.org>
Subject: [PATCH v1 10/18] staging: gpib: hp_82335: struct gpib_interface
Date: Tue, 8 Apr 2025 22:24:56 +0000 [thread overview]
Message-ID: <20250408222504.186992-11-matchstick@neverthere.org> (raw)
In-Reply-To: <20250408222504.186992-1-matchstick@neverthere.org>
Using Linux code style for struct gpib_interface.
Adhering to Linux code style.
Reported by checkpatch.pl
In general, a pointer, or a struct that has elements that can reasonably be
directly accessed should never be a typedef.
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
---
drivers/staging/gpib/hp_82335/hp82335.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/gpib/hp_82335/hp82335.c b/drivers/staging/gpib/hp_82335/hp82335.c
index fd23b1cb80f9..1a93a456f7bd 100644
--- a/drivers/staging/gpib/hp_82335/hp82335.c
+++ b/drivers/staging/gpib/hp_82335/hp82335.c
@@ -179,7 +179,7 @@ static void hp82335_return_to_local(struct gpib_board *board)
tms9914_return_to_local(board, &priv->tms9914_priv);
}
-static gpib_interface_t hp82335_interface = {
+static struct gpib_interface hp82335_interface = {
.name = "hp82335",
.attach = hp82335_attach,
.detach = hp82335_detach,
--
2.43.0
next prev parent reply other threads:[~2025-04-08 22:25 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-08 22:24 [PATCH v1 00/18] staging: gpib: Removing typedef of gpib_interface_t Michael Rubin
2025-04-08 22:24 ` [PATCH v1 01/18] staging: gpib: struct typing for gpib_interface Michael Rubin
2025-04-09 8:26 ` Dan Carpenter
2025-04-09 17:52 ` Michael Rubin
2025-04-15 14:41 ` Greg KH
2025-04-16 20:45 ` Michael Rubin
2025-04-08 22:24 ` [PATCH v1 02/18] staging: gpib: agilent_82350b: gpib_interface Michael Rubin
2025-04-08 22:24 ` [PATCH v1 03/18] staging: gpib: agilent_82357a: gpib_interface Michael Rubin
2025-04-08 22:24 ` [PATCH v1 04/18] staging: gpib: cb7210: struct gpib_interface Michael Rubin
2025-04-08 22:24 ` [PATCH v1 05/18] staging: gpib: cec: " Michael Rubin
2025-04-08 22:24 ` [PATCH v1 06/18] staging: gpib: common: " Michael Rubin
2025-04-08 22:24 ` [PATCH v1 07/18] staging: gpib: fluke: " Michael Rubin
2025-04-08 22:24 ` [PATCH v1 08/18] staging: gpib: fmh: " Michael Rubin
2025-04-08 22:24 ` [PATCH v1 09/18] staging: gpib: gpio: " Michael Rubin
2025-04-08 22:24 ` Michael Rubin [this message]
2025-04-08 22:24 ` [PATCH v1 11/18] staging: gpib: hp2341: " Michael Rubin
2025-04-08 22:24 ` [PATCH v1 12/18] staging: gpib: gpibP: " Michael Rubin
2025-04-08 22:24 ` [PATCH v1 13/18] staging: gpib: ines: " Michael Rubin
2025-04-08 22:25 ` [PATCH v1 14/18] staging: gpib: lpvo_usb: " Michael Rubin
2025-04-08 22:25 ` [PATCH v1 15/18] staging: gpib: ni_usb: " Michael Rubin
2025-04-08 22:25 ` [PATCH v1 16/18] staging: gpib: pc2: " Michael Rubin
2025-04-08 22:25 ` [PATCH v1 17/18] staging: gpib: tnt4882: " Michael Rubin
2025-04-08 22:25 ` [PATCH v1 18/18] staging: gpib: Removing typedef gpib_interface_t Michael Rubin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250408222504.186992-11-matchstick@neverthere.org \
--to=matchstick@neverthere.org \
--cc=dpenkler@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox