Re: [Patch v1 01/21] staging: gpib: Using struct gpib_board_type_ioctl

Dave Penkler
2025-04-09T08:56:46Z

On Wed, Apr 09, 2025 at 11:10:41AM +0300, Dan Carpenter wrote:
> On Wed, Apr 09, 2025 at 05:58:43AM +0000, Michael Rubin wrote:
> > diff --git a/drivers/staging/gpib/uapi/gpib_ioctl.h b/drivers/staging/gpib/uapi/gpib_ioctl.h
> > index 6202865278ea..4ddcbc2a81b0 100644
> > --- a/drivers/staging/gpib/uapi/gpib_ioctl.h
> > +++ b/drivers/staging/gpib/uapi/gpib_ioctl.h
> > @@ -12,9 +12,9 @@
> >
> > #define GPIB_CODE 160
> >
> > -typedef struct {
> > +struct gpib_board_type_ioctl {
> > char name[100];
> > -} board_type_ioctl_t;
> > +};
>
> This breaks user API so now user space can't compile. I don't think
> any of these 21 patches can be applied.
>
> regards,
> dan carpenter
>

These patches are OK. I will make a new release of the userspace libraries
with a compat include that defines the typedefs.
cheers,
-Dave