From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 09B071DF72E for ; Wed, 9 Apr 2025 05:59:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744178354; cv=none; b=d9riekgP6uUzpRk3RPG3ivHKg9fEbVEg46J9tl8yB+mz2BVZdNdxLZXnX3KQrLRsw9o+dsysPThpsGJEA/EU1LcEyZnYRK2ZzbIKrK1O+79yb4lm8dqfF5dncIuZaZ1vm0PE6MfUE1dqQrPrM2LZJVIyoMBbb2Y9zq8DTM8JJ3k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744178354; c=relaxed/simple; bh=6/tEDWkyWZGqddA6x5CupLdQkjAI7dTnTj5CqszFug8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ciw4emQYIbnNHzmqfv+V3S11NwbUVmO4b2BBurQzwXTFa7H5/CZxziSHyUdVgxgqE5njhgSTRfeNpYWUoQXRFaFbhg1UEutU8m1fnamZiRtBcEHBPG4tEaCBN0EHeFclB8/UW4r2BWRgHRvn5yVnMOWRJtH3fbkHf7MbSoOONlc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=FfqahHcx; arc=none smtp.client-ip=209.85.210.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="FfqahHcx" Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-7340e6f3ce1so5015662b3a.0 for ; Tue, 08 Apr 2025 22:59:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744178352; x=1744783152; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=NCoGYMLxCvRlHFRAlGxTbIygW8BXsW2zasxHkdR12QM=; b=FfqahHcxYH/grTn4yF9BAhobLOBingE1iY63XJGvL0KgdIdzfqMcKQthGOkw6iy0h4 EUyFJHN+eXWw9lgrb3iG+UvpsLAgxBzzuniN23ZmapAXHVoroHgrfJ/PyoE/vX1QNQnf /Sn86FLcVN+C4p1C+lcw+kmMOaHINi/NaS754cfb90+uxhY/K1Qr+i+kJAtZbsuUw68m upudaANt1hs3rQs9l2kcHIWDnDAQSEJ7A/hwMs12rl5TLlAbLjAPAe9JX+AE+KeoPkxt thOCPx2/YoOJY9Fpa8YDbI8pestZ6asX/Sqcb+xa2wj0j1xBtDVpCwe6LVmyqbRViDfw YC4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744178352; x=1744783152; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NCoGYMLxCvRlHFRAlGxTbIygW8BXsW2zasxHkdR12QM=; b=pHccAZ6/ChSsQDdWCDoQcskCNO/owItyF92nfKxIy7ZdSLAi4NSYr7y/1lMc4ggUQt j44hQapjDojmfYV1VODH6sE1PNQUClBN3ZHuSdh5wsQuzDQ2F1AqIT3Pm7EvhGipo1w2 lpXRv0cQH6ItLED3zRU3AsOD8I+gYQvb54uht1Ylt///r78b8p1yqEOVkQRDmthEF8LE NvD4a+PMhe6l029BtYXC20zVkr9bKGxHXJsBePDKbm67hutZVPZITIywV6Oz4Mv2ThYO YbjEBTJjvXAGHZ7oIAMNyAuCQszFGS0VjhzKKxTtFah5NSkV43u3iBwSWRNG+3qe25xL zPnQ== X-Gm-Message-State: AOJu0YxVONQQhDPbxbK2T1a5UfVD8bNHbDQp1LDB+9cvLMmkela+phUi XgP51FnOPmKBG6sJZiknrC0g5e++PDk2JF2uNmmAlA1fbZ483OWH3NgGiB68nQ== X-Gm-Gg: ASbGncvHmjeEmDNQWpK7XBXaJW8EieyGNaR9t2TIuuSAZCBdYbVVjD7kecO+uW4MBI7 vJ3mFCaeubn0BR3p6q/hRFKloqN95eJ4B8y0CyE/82vwYWyhB6dTLYZDhRmOyHmcl5FSM00AMk/ moDjiSzfcF9FzFYKzq61ghx5XGpQztQaHwmAokzQ4KwbsrxP1A993x0RGMDj8MjqSmh1vD2CtpE 5fjDz5JQ1SJ+YcDdm3nj0jOQV0/GIq0EP2vHxw0SvvVWzCpYH6fMabLQLjbwXcxuJG/W8oCOEP1 jk1QUj+W40LonGOmaGS1xFI+raxda9fnT14Bgm+ksvEVqvJmNqmxGhks4szU92cZLbzw+qLnhga okQQM2Q== X-Google-Smtp-Source: AGHT+IEnYb8oUAhH5Iqij3FjwEcu3Mi3oVa9qSFtB0jvgdjmC/mi3UyvnvAsRRmXp6OoQ75awHMGDQ== X-Received: by 2002:a05:6a00:ad6:b0:736:7a00:e522 with SMTP id d2e1a72fcca58-73bafbc6364mr1740723b3a.2.1744178352232; Tue, 08 Apr 2025 22:59:12 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73bb1d4945asm441176b3a.68.2025.04.08.22.59.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 22:59:12 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Rubin Subject: [Patch v1 05/21] staging: gpib: Using struct gpib_serial_poll_ioctl Date: Wed, 9 Apr 2025 05:58:47 +0000 Message-ID: <20250409055903.321438-6-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250409055903.321438-1-matchstick@neverthere.org> References: <20250409055903.321438-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Using Linux code style for 'struct gpib_serial_poll_ioctl' to remove typedef. Adhering to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin --- drivers/staging/gpib/common/gpib_os.c | 2 +- drivers/staging/gpib/uapi/gpib_ioctl.h | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/gpib/common/gpib_os.c b/drivers/staging/gpib/common/gpib_os.c index 4d105db18447..9f7becb09e60 100644 --- a/drivers/staging/gpib/common/gpib_os.c +++ b/drivers/staging/gpib/common/gpib_os.c @@ -1289,7 +1289,7 @@ static int close_dev_ioctl(struct file *filep, struct gpib_board *board, unsigne static int serial_poll_ioctl(struct gpib_board *board, unsigned long arg) { - serial_poll_ioctl_t serial_cmd; + struct gpib_serial_poll_ioctl serial_cmd; int retval; retval = copy_from_user(&serial_cmd, (void __user *)arg, sizeof(serial_cmd)); diff --git a/drivers/staging/gpib/uapi/gpib_ioctl.h b/drivers/staging/gpib/uapi/gpib_ioctl.h index 6ea6114ae78a..9be3262271c5 100644 --- a/drivers/staging/gpib/uapi/gpib_ioctl.h +++ b/drivers/staging/gpib/uapi/gpib_ioctl.h @@ -36,11 +36,11 @@ struct gpib_close_dev_ioctl { unsigned int handle; }; -typedef struct { +struct gpib_serial_poll_ioctl { unsigned int pad; int sad; uint8_t status_byte; -} serial_poll_ioctl_t; +}; typedef struct { int eos; @@ -137,7 +137,7 @@ enum gpib_ioctl { IBPAD = _IOW(GPIB_CODE, 15, pad_ioctl_t), IBSAD = _IOW(GPIB_CODE, 16, sad_ioctl_t), IBTMO = _IOW(GPIB_CODE, 17, unsigned int), - IBRSP = _IOWR(GPIB_CODE, 18, serial_poll_ioctl_t), + IBRSP = _IOWR(GPIB_CODE, 18, struct gpib_serial_poll_ioctl), IBEOS = _IOW(GPIB_CODE, 19, eos_ioctl_t), IBRSV = _IOW(GPIB_CODE, 20, uint8_t), CFCBASE = _IOW(GPIB_CODE, 21, uint64_t), -- 2.43.0