From: Siddarth G <siddarthsgml@gmail.com>
To: slongerbeam@gmail.com, p.zabel@pengutronix.de,
mchehab@kernel.org, gregkh@linuxfoundation.org,
shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com
Cc: linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, skhan@linuxfoundation.org,
Siddarth G <siddarthsgml@gmail.com>
Subject: [PATCH v2] media: imx: Fix NULL pointer dereference
Date: Thu, 10 Apr 2025 10:35:43 +0530 [thread overview]
Message-ID: <20250410050543.6963-1-siddarthsgml@gmail.com> (raw)
Cppcheck warnings:
drivers/staging/media/imx/imx-media-fim.c:79:6:
error: Null pointer dereference: fi [ctunullpointer]
if (fi->denominator == 0) {
drivers/staging/media/imx/imx-media-csi.c:795:27:
note: Calling function imx_media_fim_set_stream, 2nd argument is null
imx_media_fim_set_stream(priv->fim, NULL, false);
drivers/staging/media/imx/imx-media-fim.c:388:3:
note: Calling function update_fim_nominal, 2nd argument is null
update_fim_nominal(fim, fi);
drivers/staging/media/imx/imx-media-fim.c:79:6:
note: Dereferencing argument fi that is null
if (fi->denominator == 0) {
To fix the issue, add a check to validate that the 'fi' is not
null before accessing its members.
Signed-off-by: Siddarth G <siddarthsgml@gmail.com>
---
Changes since v1:
- added "media:" prefix in subject
drivers/staging/media/imx/imx-media-fim.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/staging/media/imx/imx-media-fim.c b/drivers/staging/media/imx/imx-media-fim.c
index ccbc0371fba2..25f79d0f87b9 100644
--- a/drivers/staging/media/imx/imx-media-fim.c
+++ b/drivers/staging/media/imx/imx-media-fim.c
@@ -76,6 +76,9 @@ static bool icap_enabled(struct imx_media_fim *fim)
static void update_fim_nominal(struct imx_media_fim *fim,
const struct v4l2_fract *fi)
{
+ if (!fi)
+ return;
+
if (fi->denominator == 0) {
dev_dbg(fim->sd->dev, "no frame interval, FIM disabled\n");
fim->enabled = false;
--
2.43.0
next reply other threads:[~2025-04-10 5:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-10 5:05 Siddarth G [this message]
2025-04-10 6:19 ` [PATCH v2] media: imx: Fix NULL pointer dereference Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250410050543.6963-1-siddarthsgml@gmail.com \
--to=siddarthsgml@gmail.com \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=slongerbeam@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox