From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-staging@lists.linux.dev
Subject: Re: [PATCH] iio: normalize array sentinel style
Date: Sun, 13 Apr 2025 10:39:50 +0100 [thread overview]
Message-ID: <20250413103950.23c20bd3@jic23-huawei> (raw)
In-Reply-To: <CAHp75VcdpPC2faWNMupXL-RaEM3QsSYEyfSC+A7KEsmD24U=+Q@mail.gmail.com>
On Sat, 12 Apr 2025 15:55:35 +0300
Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> On Fri, Apr 11, 2025 at 11:50 PM David Lechner <dlechner@baylibre.com> wrote:
> >
> > Use `\t(\{ ?\},|\{\}|\{\s*/\*.*\*/\s*\},?)$` regex to find and replace
> > the array sentinel in all IIO drivers to the same style.
> >
> > For some time, we've been trying to consistently use `{ }` (no trailing
> > comma, no comment, one space between braces) for array sentinels in the
> > IIO subsystem. Still nearly 50% of existing code uses a different style.
> > To save reviewers from having to request this trivial change as
> > frequently, let's normalize the style in all existing IIO drivers.
> > At least when code is copy/pasted to new drivers, the style will be
> > consistent.
>
> With or without iiner space, but same style. What is important is that
> you removed the trailing commas.
> Reviewed-by: Andy Shevchenko <andy@kernel.org>
>
Agreed. The space thing was a random choice, but consistency is good
and comma part matters more.
Applied. One case had already gone away in my tree and there was a little
fuzz but should all be fine.
Thanks,
Jonathan
prev parent reply other threads:[~2025-04-13 9:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-11 20:49 [PATCH] iio: normalize array sentinel style David Lechner
2025-04-12 12:55 ` Andy Shevchenko
2025-04-13 9:39 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250413103950.23c20bd3@jic23-huawei \
--to=jic23@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox